From: Paul Moore <paul@paul-moore.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
LKML <linux-kernel@vger.kernel.org>,
selinux@tycho.nsa.gov
Subject: Re: [PATCH 1/2] selinux: simple cleanup for cond_read_node()
Date: Thu, 19 Jun 2014 14:59:04 -0400 [thread overview]
Message-ID: <18713609.X6uzY7R5jD@sifl> (raw)
In-Reply-To: <CAM9d7cj07=ERVUnEhpCu6g72HsXCFSFmha8U6BZL6BbYBxckEg@mail.gmail.com>
On Thursday, June 19, 2014 08:58:31 AM Namhyung Kim wrote:
> Hi Paul,
>
> On Thu, Jun 19, 2014 at 4:36 AM, Paul Moore <paul@paul-moore.com> wrote:
> > > @@ -402,19 +402,14 @@ static int cond_read_node(struct policydb *p,
> > > struct
> >>
> >> cond_node *node, void *fp) int rc;
> >>
> >> struct cond_expr *expr = NULL, *last = NULL;
> >>
> >> - rc = next_entry(buf, fp, sizeof(u32));
> >> + rc = next_entry(buf, fp, sizeof(buf));
> >
> > This is a bit nit-picky, but how about using "sizeof(u32) * 2"? It is
> > more
> > consistent with the rest of the function and helps underscore that we are
> > reading two 32-bit values.
> >
> > Assuming you're okay with the change I can fix it up when I apply the
> > patch.
>
> I'm okay with it. :)
Great, both patches are applied.
--
paul moore
www.paul-moore.com
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <paul@paul-moore.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
selinux@tycho.nsa.gov, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] selinux: simple cleanup for cond_read_node()
Date: Thu, 19 Jun 2014 14:59:04 -0400 [thread overview]
Message-ID: <18713609.X6uzY7R5jD@sifl> (raw)
In-Reply-To: <CAM9d7cj07=ERVUnEhpCu6g72HsXCFSFmha8U6BZL6BbYBxckEg@mail.gmail.com>
On Thursday, June 19, 2014 08:58:31 AM Namhyung Kim wrote:
> Hi Paul,
>
> On Thu, Jun 19, 2014 at 4:36 AM, Paul Moore <paul@paul-moore.com> wrote:
> > > @@ -402,19 +402,14 @@ static int cond_read_node(struct policydb *p,
> > > struct
> >>
> >> cond_node *node, void *fp) int rc;
> >>
> >> struct cond_expr *expr = NULL, *last = NULL;
> >>
> >> - rc = next_entry(buf, fp, sizeof(u32));
> >> + rc = next_entry(buf, fp, sizeof(buf));
> >
> > This is a bit nit-picky, but how about using "sizeof(u32) * 2"? It is
> > more
> > consistent with the rest of the function and helps underscore that we are
> > reading two 32-bit values.
> >
> > Assuming you're okay with the change I can fix it up when I apply the
> > patch.
>
> I'm okay with it. :)
Great, both patches are applied.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2014-06-19 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-14 16:19 [PATCH 1/2] selinux: simple cleanup for cond_read_node() Namhyung Kim
2014-06-14 16:19 ` Namhyung Kim
2014-06-14 16:19 ` [PATCH 2/2] selinux: fix a possible memory leak in cond_read_node() Namhyung Kim
2014-06-14 16:19 ` Namhyung Kim
2014-06-18 19:41 ` Paul Moore
2014-06-18 19:41 ` Paul Moore
2014-06-18 19:36 ` [PATCH 1/2] selinux: simple cleanup for cond_read_node() Paul Moore
2014-06-18 19:36 ` Paul Moore
2014-06-18 23:58 ` Namhyung Kim
2014-06-18 23:58 ` Namhyung Kim
2014-06-19 18:59 ` Paul Moore [this message]
2014-06-19 18:59 ` Paul Moore
2014-06-19 12:03 ` Stephen Smalley
2014-06-19 12:03 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18713609.X6uzY7R5jD@sifl \
--to=paul@paul-moore.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.