From: Paul Mackerras <paulus@samba.org>
To: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux PPC devel <linuxppc-dev@ozlabs.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync
Date: Wed, 3 Dec 2008 20:17:13 +1100 [thread overview]
Message-ID: <18742.20121.759577.660481@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20081118113848.945650506@linux.vnet.ibm.com>
Hendrik Brueckner writes:
> From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
>
> The test to check for a new winsize runs out-of-sync with the underlying
> tty. After a tty has been released and initialized again, the winsize might
> differ between the tty and the hp struct.
> The solution is to simply remove the check and always schedule the resize work.
Looks OK. Is this going to go in via the s390 tree, or should I put
it in the powerpc tree?
Paul.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@samba.org>
To: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux PPC devel <linuxppc-dev@ozlabs.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Rusty Russell <rusty@rustcorp.com.au>,
"Ryan S. Arnold" <rsa@us.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync
Date: Wed, 3 Dec 2008 20:17:13 +1100 [thread overview]
Message-ID: <18742.20121.759577.660481@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <20081118113848.945650506@linux.vnet.ibm.com>
Hendrik Brueckner writes:
> From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
>
> The test to check for a new winsize runs out-of-sync with the underlying
> tty. After a tty has been released and initialized again, the winsize might
> differ between the tty and the hp struct.
> The solution is to simply remove the check and always schedule the resize work.
Looks OK. Is this going to go in via the s390 tree, or should I put
it in the powerpc tree?
Paul.
next prev parent reply other threads:[~2008-12-03 9:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 11:28 [patch 0/1] hvc_console: fix: remove duplicate hp->ws winsize check Hendrik Brueckner
2008-11-18 11:28 ` Hendrik Brueckner
2008-11-18 11:28 ` [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync Hendrik Brueckner
2008-11-18 11:28 ` Hendrik Brueckner
2008-12-03 9:17 ` Paul Mackerras [this message]
2008-12-03 9:17 ` Paul Mackerras
2008-12-03 9:28 ` Hendrik Brueckner
2008-12-03 9:28 ` Hendrik Brueckner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18742.20121.759577.660481@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=borntraeger@de.ibm.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rusty@rustcorp.com.au \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.