From: Neeraj Kumar <s.neeraj@samsung.com>
To: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
linux-kernel@vger.kernel.org, gost.dev@samsung.com
Cc: a.manzanares@samsung.com, vishak.g@samsung.com,
neeraj.kernel@gmail.com, cpgs@samsung.com,
Neeraj Kumar <s.neeraj@samsung.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Ira Weiny <ira.weiny@intel.com>
Subject: [PATCH V3 02/20] nvdimm/label: CXL labels skip the need for 'interleave-set cookie'
Date: Wed, 17 Sep 2025 19:10:58 +0530 [thread overview]
Message-ID: <1891546521.01758169682623.JavaMail.epsvc@epcpadp2new> (raw)
In-Reply-To: <20250917134116.1623730-1-s.neeraj@samsung.com>
CXL LSA v2.1 utilizes the region labels stored in the LSA for interleave
set configuration instead of interleave-set cookie used in previous LSA
versions. As interleave-set cookie is not required for CXL LSA v2.1 format
so skip its usage for CXL LSA 2.1 format
Signed-off-by: Neeraj Kumar <s.neeraj@samsung.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Acked-by: Ira Weiny <ira.weiny@intel.com>
---
drivers/nvdimm/namespace_devs.c | 8 +++++++-
drivers/nvdimm/region_devs.c | 10 ++++++++++
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
index 55cfbf1e0a95..3271b1c8569a 100644
--- a/drivers/nvdimm/namespace_devs.c
+++ b/drivers/nvdimm/namespace_devs.c
@@ -1684,7 +1684,13 @@ static struct device *create_namespace_pmem(struct nd_region *nd_region,
int rc = 0;
u16 i;
- if (cookie == 0) {
+ /*
+ * CXL LSA v2.1 utilizes the region label stored in the LSA for
+ * interleave set configuration. Whereas EFI LSA v1.1 & v1.2
+ * utilizes interleave-set cookie. i.e, CXL labels skip the
+ * need for 'interleave-set cookie'
+ */
+ if (!ndd->cxl && cookie == 0) {
dev_dbg(&nd_region->dev, "invalid interleave-set-cookie\n");
return ERR_PTR(-ENXIO);
}
diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c
index de1ee5ebc851..88275f352240 100644
--- a/drivers/nvdimm/region_devs.c
+++ b/drivers/nvdimm/region_devs.c
@@ -858,6 +858,16 @@ u64 nd_region_interleave_set_cookie(struct nd_region *nd_region,
if (!nd_set)
return 0;
+ /*
+ * CXL LSA v2.1 utilizes the region label stored in the LSA for
+ * interleave set configuration. Whereas EFI LSA v1.1 & v1.2
+ * utilizes interleave-set cookie. i.e, CXL labels skip the
+ * need for 'interleave-set cookie'
+ */
+ if (nsindex && __le16_to_cpu(nsindex->major) == 2
+ && __le16_to_cpu(nsindex->minor) == 1)
+ return 0;
+
if (nsindex && __le16_to_cpu(nsindex->major) == 1
&& __le16_to_cpu(nsindex->minor) == 1)
return nd_set->cookie1;
--
2.34.1
next prev parent reply other threads:[~2025-09-18 4:28 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250917134126epcas5p3e20c773759b91f70a1caa32b9f6f27ff@epcas5p3.samsung.com>
2025-09-17 13:40 ` [PATCH V3 00/20] Add CXL LSA 2.1 format support in nvdimm and cxl pmem Neeraj Kumar
2025-09-17 13:40 ` [PATCH V3 01/20] nvdimm/label: Introduce NDD_REGION_LABELING flag to set region label Neeraj Kumar
2025-09-19 23:10 ` Dave Jiang
2025-09-22 12:41 ` Neeraj Kumar
2025-09-17 13:40 ` Neeraj Kumar [this message]
2025-09-19 23:31 ` [PATCH V3 02/20] nvdimm/label: CXL labels skip the need for 'interleave-set cookie' Dave Jiang
2025-09-17 13:40 ` [PATCH V3 03/20] nvdimm/label: Modify nd_label_base() signature Neeraj Kumar
2025-09-19 21:42 ` Ira Weiny
2025-09-19 23:34 ` Dave Jiang
2025-09-22 12:44 ` Neeraj Kumar
2025-09-24 21:02 ` Alison Schofield
2025-09-29 14:07 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 04/20] nvdimm/label: Update mutex_lock() with guard(mutex)() Neeraj Kumar
2025-09-19 21:55 ` Ira Weiny
2025-09-22 12:56 ` Neeraj Kumar
2025-09-19 23:50 ` Dave Jiang
2025-09-20 17:44 ` Ira Weiny
2025-09-22 13:01 ` Neeraj Kumar
2025-09-24 21:42 ` Alison Schofield
2025-09-29 14:19 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 05/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1 Neeraj Kumar
2025-09-17 14:54 ` Jonathan Cameron
2025-09-19 22:00 ` Ira Weiny
2025-09-22 13:05 ` Neeraj Kumar
2025-09-19 23:59 ` Dave Jiang
2025-09-22 13:03 ` Neeraj Kumar
2025-09-23 21:48 ` Dave Jiang
2025-09-29 13:28 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 06/20] nvdimm/region_label: Add region label update support Neeraj Kumar
2025-09-17 15:36 ` Jonathan Cameron
2025-09-22 13:12 ` Neeraj Kumar
2025-10-06 16:56 ` Dave Jiang
2025-09-22 23:11 ` Dave Jiang
2025-09-29 13:24 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 07/20] nvdimm/region_label: Add region label delete support Neeraj Kumar
2025-09-22 21:37 ` Dave Jiang
2025-09-29 13:13 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 08/20] nvdimm/label: Include region label in slot validation Neeraj Kumar
2025-09-22 22:17 ` Dave Jiang
2025-09-29 13:17 ` Neeraj Kumar
2025-09-24 21:30 ` Alison Schofield
2025-09-29 14:10 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 09/20] nvdimm/namespace_label: Skip region label during ns label DPA reservation Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 10/20] nvdimm/namespace_label: Skip region label during namespace creation Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 11/20] nvdimm/region_label: Preserve cxl region information from region label Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 12/20] nvdimm/region_label: Export routine to fetch region information Neeraj Kumar
2025-09-23 20:23 ` Dave Jiang
2025-09-29 13:26 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 13/20] cxl/mem: Refactor cxl pmem region auto-assembling Neeraj Kumar
2025-09-23 22:37 ` Dave Jiang
2025-09-29 13:30 ` Neeraj Kumar
2025-10-06 15:55 ` Dave Jiang
2025-11-07 12:39 ` Neeraj Kumar
2025-11-12 15:55 ` Dave Jiang
2025-11-13 7:27 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 14/20] cxl/region: Add devm_cxl_pmem_add_region() for pmem region creation Neeraj Kumar
2025-09-23 23:50 ` Dave Jiang
2025-09-29 13:37 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 15/20] cxl: Add a routine to find cxl root decoder on cxl bus using cxl port Neeraj Kumar
2025-09-24 18:11 ` Dave Jiang
2025-09-29 13:40 ` Neeraj Kumar
2025-10-06 16:02 ` Dave Jiang
2025-09-17 13:41 ` [PATCH V3 16/20] cxl/mem: Preserve cxl root decoder during mem probe Neeraj Kumar
2025-09-24 18:23 ` Dave Jiang
2025-09-29 13:52 ` Neeraj Kumar
2025-09-24 21:38 ` Alison Schofield
2025-09-29 14:13 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 17/20] cxl/pmem: Preserve region information into nd_set Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 18/20] cxl/pmem_region: Prep patch to accommodate pmem_region attributes Neeraj Kumar
2025-09-24 18:53 ` Dave Jiang
2025-09-29 13:57 ` Neeraj Kumar
2025-10-06 16:06 ` Dave Jiang
2025-11-07 12:49 ` Neeraj Kumar
2025-11-12 15:40 ` Dave Jiang
2025-11-13 7:29 ` Neeraj Kumar
2025-10-06 16:09 ` Dave Jiang
2025-09-17 13:41 ` [PATCH V3 19/20] cxl/pmem_region: Add sysfs attribute cxl region label updation/deletion Neeraj Kumar
2025-09-24 20:25 ` Dave Jiang
2025-09-29 14:00 ` Neeraj Kumar
2025-09-17 13:41 ` [PATCH V3 20/20] cxl/pmem: Add CXL LSA 2.1 support in cxl pmem Neeraj Kumar
2025-09-24 20:47 ` Dave Jiang
2025-09-29 14:02 ` Neeraj Kumar
2025-10-06 16:13 ` Dave Jiang
2025-09-17 14:50 ` [PATCH V3 00/20] Add CXL LSA 2.1 format support in nvdimm and " Jonathan Cameron
2025-09-17 15:38 ` Dave Jiang
2025-09-22 12:36 ` Neeraj Kumar
2025-09-23 23:04 ` Alison Schofield
2025-09-29 13:33 ` Neeraj Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1891546521.01758169682623.JavaMail.epsvc@epcpadp2new \
--to=s.neeraj@samsung.com \
--cc=a.manzanares@samsung.com \
--cc=cpgs@samsung.com \
--cc=gost.dev@samsung.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraj.kernel@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishak.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.