All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
	"Rob Herring (Arm)" <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	kernel@collabora.com, FUKAUMI Naoki <naoki@radxa.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v2 0/5] arm64: dts: rockchip: add ROCK 5B+ support
Date: Fri, 09 May 2025 17:12:22 +0200	[thread overview]
Message-ID: <1893373.atdPhlSkOF@diego> (raw)
In-Reply-To: <174679985287.3369051.14227124355079340433.robh@kernel.org>

Am Freitag, 9. Mai 2025, 16:17:02 Mitteleuropäische Sommerzeit schrieb Rob Herring (Arm):
> 
> On Thu, 08 May 2025 19:48:49 +0200, Sebastian Reichel wrote:
> > This series adds support for the ROCK 5B+, which (as the name suggests)
> > is an improved version of the ROCK 5B. It also adds initial USB-C
> > support for both the ROCK 5B and the 5B+.
> > 
> > Changes in PATCHv2:
> >  - Link to v1: https://lore.kernel.org/r/20250324-rock5bp-for-upstream-v1-0-6217edf15b19@kernel.org
> >  - Replaced DT binding patch with the version from NAOKI
> >  - Dropped unused pinctrl for vcc5v0_host_en from the shared DT
> >  - Moved USB-C SBU DC pins to board specific files, since they differ
> >    between Rock 5B and Rock 5B+
> >  - Added pinmux for SBU DC pins
> >  - Rebased to latest version of Heiko's for-next branch
> >  - Disable USB-C on Rock 5B for now
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> > FUKAUMI Naoki (1):
> >       dt-bindings: arm: rockchip: Add Radxa ROCK 5B+
> > 
> > Sebastian Reichel (4):
> >       arm64: dts: rockchip: move rock 5b to include file
> >       arm64: dts: rockchip: move rock 5b to include file
> >       arm64: dts: rockchip: add Rock 5B+
> >       arm64: dts: rockchip: add USB-C support for ROCK 5B+
> > 
> >  .../devicetree/bindings/arm/rockchip.yaml          |    5 +
> >  arch/arm64/boot/dts/rockchip/Makefile              |    1 +
> >  .../boot/dts/rockchip/rk3588-rock-5b-plus.dts      |  129 +++
> >  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts    |  970 +-----------------
> >  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi   | 1082 ++++++++++++++++++++
> >  5 files changed, 1247 insertions(+), 940 deletions(-)
> > ---
> > base-commit: b7caeb9545db25649eda36ce593b70cc2aa804ab
> > change-id: 20250324-rock5bp-for-upstream-fd85b00b593b
> > 
> > Best regards,
> > --
> > Sebastian Reichel <sre@kernel.org>
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: base-commit b7caeb9545db25649eda36ce593b70cc2aa804ab not known, ignoring
>  Base: attempting to guess base-commit...
>  Base: tags/v6.15-rc1-40-g425af91c5802 (best guess, 2/3 blobs matched)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org:
> 
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /edp@fdec0000: failed to match any schema with compatible: ['rockchip,rk3588-edp']
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /edp@fded0000: failed to match any schema with compatible: ['rockchip,rk3588-edp']

This should be already fixed by the rk3588-edp addition in linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f855146263b14abadd8d5bd0e280e54fbab3bd18




WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
	"Rob Herring (Arm)" <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	kernel@collabora.com, FUKAUMI Naoki <naoki@radxa.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v2 0/5] arm64: dts: rockchip: add ROCK 5B+ support
Date: Fri, 09 May 2025 17:12:22 +0200	[thread overview]
Message-ID: <1893373.atdPhlSkOF@diego> (raw)
In-Reply-To: <174679985287.3369051.14227124355079340433.robh@kernel.org>

Am Freitag, 9. Mai 2025, 16:17:02 Mitteleuropäische Sommerzeit schrieb Rob Herring (Arm):
> 
> On Thu, 08 May 2025 19:48:49 +0200, Sebastian Reichel wrote:
> > This series adds support for the ROCK 5B+, which (as the name suggests)
> > is an improved version of the ROCK 5B. It also adds initial USB-C
> > support for both the ROCK 5B and the 5B+.
> > 
> > Changes in PATCHv2:
> >  - Link to v1: https://lore.kernel.org/r/20250324-rock5bp-for-upstream-v1-0-6217edf15b19@kernel.org
> >  - Replaced DT binding patch with the version from NAOKI
> >  - Dropped unused pinctrl for vcc5v0_host_en from the shared DT
> >  - Moved USB-C SBU DC pins to board specific files, since they differ
> >    between Rock 5B and Rock 5B+
> >  - Added pinmux for SBU DC pins
> >  - Rebased to latest version of Heiko's for-next branch
> >  - Disable USB-C on Rock 5B for now
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> > FUKAUMI Naoki (1):
> >       dt-bindings: arm: rockchip: Add Radxa ROCK 5B+
> > 
> > Sebastian Reichel (4):
> >       arm64: dts: rockchip: move rock 5b to include file
> >       arm64: dts: rockchip: move rock 5b to include file
> >       arm64: dts: rockchip: add Rock 5B+
> >       arm64: dts: rockchip: add USB-C support for ROCK 5B+
> > 
> >  .../devicetree/bindings/arm/rockchip.yaml          |    5 +
> >  arch/arm64/boot/dts/rockchip/Makefile              |    1 +
> >  .../boot/dts/rockchip/rk3588-rock-5b-plus.dts      |  129 +++
> >  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts    |  970 +-----------------
> >  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtsi   | 1082 ++++++++++++++++++++
> >  5 files changed, 1247 insertions(+), 940 deletions(-)
> > ---
> > base-commit: b7caeb9545db25649eda36ce593b70cc2aa804ab
> > change-id: 20250324-rock5bp-for-upstream-fd85b00b593b
> > 
> > Best regards,
> > --
> > Sebastian Reichel <sre@kernel.org>
> > 
> > 
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: base-commit b7caeb9545db25649eda36ce593b70cc2aa804ab not known, ignoring
>  Base: attempting to guess base-commit...
>  Base: tags/v6.15-rc1-40-g425af91c5802 (best guess, 2/3 blobs matched)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250508-rock5bp-for-upstream-v2-0-677033cc1ac2@kernel.org:
> 
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /edp@fdec0000: failed to match any schema with compatible: ['rockchip,rk3588-edp']
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus.dtb: /edp@fded0000: failed to match any schema with compatible: ['rockchip,rk3588-edp']

This should be already fixed by the rk3588-edp addition in linux-next:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=f855146263b14abadd8d5bd0e280e54fbab3bd18



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-05-09 20:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 17:48 [PATCH v2 0/5] arm64: dts: rockchip: add ROCK 5B+ support Sebastian Reichel
2025-05-08 17:48 ` Sebastian Reichel
2025-05-08 17:48 ` [PATCH v2 1/5] arm64: dts: rockchip: move rock 5b to include file Sebastian Reichel
2025-05-08 17:48   ` Sebastian Reichel
2025-05-08 17:48 ` [PATCH v2 2/5] " Sebastian Reichel
2025-05-08 17:48   ` Sebastian Reichel
2025-05-09 12:44   ` Diederik de Haas
2025-05-09 12:44     ` Diederik de Haas
2025-05-09 12:54     ` Heiko Stübner
2025-05-09 12:54       ` Heiko Stübner
2025-05-09 13:08       ` Sebastian Reichel
2025-05-09 13:08         ` Sebastian Reichel
2025-05-09 13:14         ` Diederik de Haas
2025-05-09 13:14           ` Diederik de Haas
2025-05-08 17:48 ` [PATCH v2 3/5] dt-bindings: arm: rockchip: Add Radxa ROCK 5B+ Sebastian Reichel
2025-05-08 17:48   ` Sebastian Reichel
2025-05-08 17:48 ` [PATCH v2 4/5] arm64: dts: rockchip: add Rock 5B+ Sebastian Reichel
2025-05-08 17:48   ` Sebastian Reichel
2025-05-08 17:48 ` [PATCH v2 5/5] arm64: dts: rockchip: add USB-C support for ROCK 5B+ Sebastian Reichel
2025-05-08 17:48   ` Sebastian Reichel
2025-05-09 13:18   ` Diederik de Haas
2025-05-09 13:18     ` Diederik de Haas
2025-05-09 14:17     ` Sebastian Reichel
2025-05-09 14:17       ` Sebastian Reichel
2025-05-09 14:17 ` [PATCH v2 0/5] arm64: dts: rockchip: add ROCK 5B+ support Rob Herring (Arm)
2025-05-09 14:17   ` Rob Herring (Arm)
2025-05-09 15:12   ` Heiko Stübner [this message]
2025-05-09 15:12     ` Heiko Stübner
2025-05-09 17:50     ` Sebastian Reichel
2025-05-09 17:50       ` Sebastian Reichel
2025-05-09 20:00 ` (subset) " Heiko Stuebner
2025-05-09 20:00   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1893373.atdPhlSkOF@diego \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=naoki@radxa.com \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.