All of lore.kernel.org
 help / color / mirror / Atom feed
From: tridge@samba.org
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
	Steve French <sfrench@us.ibm.com>, Mingming Cao <cmm@us.ibm.com>,
	Paul McKenney <paulmck@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES option
Date: Sat, 2 May 2009 21:13:02 +1000	[thread overview]
Message-ID: <18940.10942.989329.993465@samba.org> (raw)
In-Reply-To: <87ab5v9381.fsf@devron.myhome.or.jp>

Hi Hirofumi-san,

 > It may be ok. However, of course, it should consider other than
 > ascii. Well, I think the patch should be allow only perfect 8.3 name in
 > vfat_create_shortname(). (i.e. is_shortname && base/ext_info.valid)

ok, so something like this in vfat_create_shortname() ?

#ifdef CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES
	if (is_shortname == 0 ||
	    !(base_info.valid && ext_info.valid))
		return -ENAMETOOLONG;
	shortname_flags = VFAT_SFN_CREATE_WINNT;
#endif

that still means that creating a file ShortNam.TxT actually creates
shortnam.txt on disk. Will the case-insensitive vfat_cmpi used as
d_compare cope OK with that?

Cheers, Tridge

  reply	other threads:[~2009-05-02 11:13 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-01 17:41 [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES option Dave Kleikamp
2009-05-01 17:47 ` Christoph Hellwig
2009-05-01 18:12   ` Dave Kleikamp
2009-05-01 18:19     ` Michael Tokarev
2009-05-01 19:09       ` Dave Kleikamp
2009-05-01 18:30     ` Christoph Hellwig
2009-05-02 10:09 ` OGAWA Hirofumi
2009-05-02 10:14   ` OGAWA Hirofumi
2009-05-02 10:26     ` OGAWA Hirofumi
2009-05-02 10:41       ` tridge
2009-05-02 11:03         ` OGAWA Hirofumi
2009-05-02 11:13           ` tridge [this message]
2009-05-02 11:29             ` OGAWA Hirofumi
2009-05-02 11:41               ` tridge
2009-05-02 11:59                 ` OGAWA Hirofumi
2009-05-02 12:15                   ` tridge
2009-05-02 12:48                     ` OGAWA Hirofumi
2009-05-02 13:06                       ` tridge
2009-05-02 14:01                         ` OGAWA Hirofumi
2009-05-27 12:05                   ` vimal singh
2009-05-27 12:05                     ` vimal singh
2009-05-27 23:57                     ` tridge
2009-06-04 10:26                       ` vimal singh
2009-06-04 10:26                         ` vimal singh
2009-06-04 21:33                         ` tridge
2009-05-02 10:20   ` tridge
2009-05-02 10:32     ` OGAWA Hirofumi
2009-05-03 21:56 ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2009-05-01 20:18 Steve French
2009-05-01 21:01 ` Christoph Hellwig
2009-05-02  1:37   ` Paul E. McKenney
2009-05-02  1:59     ` Matthew Wilcox
2009-05-02  3:02       ` Steve French
2009-05-02  3:02         ` Steve French
2009-05-02  4:51       ` Paul E. McKenney
2009-05-02  9:15       ` tridge
2009-05-02  9:22         ` Christoph Hellwig
2009-05-02  9:30           ` tridge
2009-05-02 12:44             ` Christoph Hellwig
2009-05-03 21:57             ` Pavel Machek
2009-05-03 22:25               ` tridge
2009-05-03 22:56                 ` Al Viro
2009-05-03 23:15                   ` tridge
2009-05-04  5:42                     ` Eric W. Biederman
2009-05-04  6:34                       ` Paul E. McKenney
2009-05-04  6:49                         ` Eric W. Biederman
2009-05-04 12:41                           ` Paul E. McKenney
2009-05-04 12:44                             ` Matthew Wilcox
2009-05-04 13:06                               ` Paul E. McKenney
2009-05-04 13:21                                 ` Matthew Wilcox
2009-05-04 14:39                                   ` Paul E. McKenney
2009-05-04 15:08                                     ` Matthew Wilcox
2009-05-04 15:36                                       ` Dave Kleikamp
2009-05-04 15:59                                         ` Eric W. Biederman
2009-05-04 16:07                                           ` Dave Kleikamp
2009-05-04 16:30                                             ` Eric W. Biederman
2009-05-04 16:42                                               ` Paul E. McKenney
2009-05-04 17:18                                                 ` Eric W. Biederman
2009-05-04 17:49                                                   ` Paul E. McKenney
2009-05-04 17:54                                                     ` Matthew Wilcox
2009-05-04 18:14                                                       ` Paul E. McKenney
2009-05-04 18:17                                                 ` Al Viro
2009-05-04 20:18                                                   ` Paul E. McKenney
2009-05-04 17:06                                               ` Olivier Galibert
2009-05-04 17:27                                                 ` Christoph Hellwig
2009-05-04 20:53                                                   ` Chris Friesen
2009-05-04 23:03                                               ` Theodore Tso
2009-05-05 11:09                                                 ` David Newall
2009-05-05 11:09                                                   ` David Newall
2009-05-05 20:56                                                   ` Valdis.Kletnieks
2009-05-05 21:04                                                     ` Christoph Hellwig
2009-05-05 22:29                                                       ` Steve French
2009-05-05 22:29                                                         ` Steve French
2009-05-04 16:11                                           ` Paul E. McKenney
2009-05-04 15:38                                       ` Paul E. McKenney
2009-05-04 15:55                                         ` Matthew Wilcox
2009-05-04 16:10                                           ` Paul E. McKenney
2009-05-04 16:22                                             ` Matthew Wilcox
2009-05-04 22:12                                               ` Greg KH
2009-05-05  2:01                                                 ` Matthew Wilcox
2009-05-05  2:11                                                   ` Paul E. McKenney
2009-05-05  2:18                                                     ` Matthew Wilcox
2009-05-05  2:18                                                       ` Matthew Wilcox
2009-05-05  3:34                                                       ` Paul E. McKenney
2009-05-05  3:34                                                         ` Paul E. McKenney
2009-05-05  8:05                                                         ` Valdis.Kletnieks
2009-05-05 15:35                                                           ` Paul E. McKenney
2009-05-05 21:00                                                             ` Valdis.Kletnieks
2009-05-05 21:56                                                               ` Paul E. McKenney
2009-05-05  3:08                                                     ` Valdis.Kletnieks
2009-05-04 15:55                                         ` Christoph Hellwig
2009-05-04 16:11                                           ` Paul E. McKenney
2009-05-04 15:40                 ` Valdis.Kletnieks
2009-05-02  6:33     ` Christoph Hellwig
2009-05-02  2:12   ` Theodore Tso
2009-05-02  6:38     ` Christoph Hellwig
2009-05-02  6:38       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18940.10942.989329.993465@samba.org \
    --to=tridge@samba.org \
    --cc=cmm@us.ibm.com \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=sfrench@us.ibm.com \
    --cc=shaggy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.