All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: "Heiko Stübner" <heiko@sntech.de>,
	mturquette@baylibre.com, "Stephen Boyd" <sboyd@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	quentin.schulz@cherry.de, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: clocks: add binding for generic clock-generators
Date: Thu, 11 Jul 2024 07:27:40 +0200	[thread overview]
Message-ID: <1899010.tdWV9SEqCh@steina-w> (raw)
In-Reply-To: <68f6dc44a8202fd83792e58aea137632.sboyd@kernel.org>

Am Donnerstag, 11. Juli 2024, 01:21:15 CEST schrieb Stephen Boyd:
> Quoting Heiko Stübner (2024-07-10 00:45:17)
> > Am Mittwoch, 10. Juli 2024, 09:02:34 CEST schrieb Alexander Stein:
> > > 
> > > So essentially only enable-gpios and vdd-supply is added in comparison to
> > > fixed-clock. Does it make sense to add that to the fixed-clocks instead?
> > > Similar to fixed-regulator.
> > 
> > I wasn't that sure which way to go in the first place.
> > The deciding point was reading that line about the fixed clock not
> > being gateable, so I opted to not touch the fixed-clock.
> > 
> > But you're definitly right, this _could_ live inside the fixed-clock
> > as well, if we decide to get rid of the not-gateable thing above.
> 
> It's probably more complicated to combine it with the fixed-clock
> binding after making properties required like vdd-supply. I'd just make
> a new binding and look at combining later.

Maybe I am missing something IMHO adding optional vdd-supply and
enable-gpios doesn't seem a big deal.
Anyway I don't have a hard opinion here. To me fixed-clocks still
seems very appropriate for having a controlling GPIO and power supply.
I just would get rid of the (comment only) hint they are ungatable.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: "Heiko Stübner" <heiko@sntech.de>,
	mturquette@baylibre.com, "Stephen Boyd" <sboyd@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	quentin.schulz@cherry.de, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: clocks: add binding for generic clock-generators
Date: Thu, 11 Jul 2024 07:27:40 +0200	[thread overview]
Message-ID: <1899010.tdWV9SEqCh@steina-w> (raw)
In-Reply-To: <68f6dc44a8202fd83792e58aea137632.sboyd@kernel.org>

Am Donnerstag, 11. Juli 2024, 01:21:15 CEST schrieb Stephen Boyd:
> Quoting Heiko Stübner (2024-07-10 00:45:17)
> > Am Mittwoch, 10. Juli 2024, 09:02:34 CEST schrieb Alexander Stein:
> > > 
> > > So essentially only enable-gpios and vdd-supply is added in comparison to
> > > fixed-clock. Does it make sense to add that to the fixed-clocks instead?
> > > Similar to fixed-regulator.
> > 
> > I wasn't that sure which way to go in the first place.
> > The deciding point was reading that line about the fixed clock not
> > being gateable, so I opted to not touch the fixed-clock.
> > 
> > But you're definitly right, this _could_ live inside the fixed-clock
> > as well, if we decide to get rid of the not-gateable thing above.
> 
> It's probably more complicated to combine it with the fixed-clock
> binding after making properties required like vdd-supply. I'd just make
> a new binding and look at combining later.

Maybe I am missing something IMHO adding optional vdd-supply and
enable-gpios doesn't seem a big deal.
Anyway I don't have a hard opinion here. To me fixed-clocks still
seems very appropriate for having a controlling GPIO and power supply.
I just would get rid of the (comment only) hint they are ungatable.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2024-07-11  5:27 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 12:31 [PATCH 0/6] Binding and driver for "dumb" clock generators Heiko Stuebner
2024-07-09 12:31 ` Heiko Stuebner
2024-07-09 12:31 ` [PATCH 1/6] dt-bindings: clocks: add binding for generic clock-generators Heiko Stuebner
2024-07-09 12:31   ` Heiko Stuebner
2024-07-09 21:45   ` Stephen Boyd
2024-07-09 21:45     ` Stephen Boyd
2024-07-10  8:02     ` Heiko Stübner
2024-07-10  8:02       ` Heiko Stübner
2024-07-10 23:56       ` Stephen Boyd
2024-07-10 23:56         ` Stephen Boyd
2024-07-10  7:02   ` Alexander Stein
2024-07-10  7:02     ` Alexander Stein
2024-07-10  7:45     ` Heiko Stübner
2024-07-10  7:45       ` Heiko Stübner
2024-07-10 23:21       ` Stephen Boyd
2024-07-10 23:21         ` Stephen Boyd
2024-07-11  5:27         ` Alexander Stein [this message]
2024-07-11  5:27           ` Alexander Stein
2024-07-15 10:59           ` Heiko Stübner
2024-07-15 10:59             ` Heiko Stübner
2024-07-09 12:31 ` [PATCH 2/6] clk: add driver for generic clock generators Heiko Stuebner
2024-07-09 12:31   ` Heiko Stuebner
2024-07-09 12:31 ` [PATCH 3/6] arm64: dts: rockchip: fix the pcie clock generator on Rock 5 ITX Heiko Stuebner
2024-07-09 12:31   ` Heiko Stuebner
2024-07-09 12:31 ` [PATCH 4/6] arm64: dts: rockchip: use clock-generator for pcie-refclk on rk3588-jaguar Heiko Stuebner
2024-07-09 12:31   ` Heiko Stuebner
2024-07-09 12:31 ` [PATCH 5/6] arm64: dts: rockchip: use clock-generator for pcie-refclk on rk3588-tiger Heiko Stuebner
2024-07-09 12:31   ` Heiko Stuebner
2024-07-09 12:31 ` [PATCH 6/6] arm64: dts: rockchip: add pinctrl for clk-generator gpio " Heiko Stuebner
2024-07-09 12:31   ` Heiko Stuebner
2024-07-10  3:02 ` [PATCH 0/6] Binding and driver for "dumb" clock generators Anand Moon
2024-07-10  3:02   ` Anand Moon
2024-07-10  7:50   ` Heiko Stübner
2024-07-10  7:50     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1899010.tdWV9SEqCh@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=quentin.schulz@cherry.de \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.