From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC 09/15] ARM: shmobile: Include DTSI of r8a7740 to armadillo800eva
Date: Wed, 21 Nov 2012 01:03:02 +0000 [thread overview]
Message-ID: <19065301.iqf7oYnrtW@avalon> (raw)
In-Reply-To: <20121121001457.GG20120@verge.net.au>
Hi Simon,
On Wednesday 21 November 2012 09:14:57 Simon Horman wrote:
> On Tue, Nov 20, 2012 at 01:45:20PM +0100, Laurent Pinchart wrote:
> > Hi Simon,
> >
> > Thank you for the patch.
> >
> > On Monday 19 November 2012 14:13:21 Simon Horman wrote:
> > > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > >
> > > Cc: Magnus Damm <damm@opensource.se>
> > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > Signed-off-by: Simon Horman <horms@verge.net.au>
> >
> > I came up today with pretty much the same patch :-)
> >
> > > ---
> > >
> > > arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > > b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts index a7505a9..a8e7bd9
> > > 100644
> > > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > > @@ -9,7 +9,7 @@
> > >
> > > */
> > >
> > > /dts-v1/;
> > >
> > > -/include/ "skeleton.dtsi"
> > > +/include/ "r8a7740.dtsi"
> > >
> > > / {
> > >
> > > model = "armadillo 800 eva";
> >
> > Shouldn't the compatible property be modified to the following values ?
> >
> > compatible = "renesas,armadillo800eva", "renesas,r8a7740";
>
> To be honest, I'm not sure.
> But as this is a dts file for a board "renesas,r8a7740" seems strange to me.
If I understand DT correctly, the goal is to get rid of the board file at some
point and only keep the generic r8a7740 board code. Shouldn't we then match on
"renesas,r8a7740" ?
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 09/15] ARM: shmobile: Include DTSI of r8a7740 to armadillo800eva
Date: Wed, 21 Nov 2012 02:03:02 +0100 [thread overview]
Message-ID: <19065301.iqf7oYnrtW@avalon> (raw)
In-Reply-To: <20121121001457.GG20120@verge.net.au>
Hi Simon,
On Wednesday 21 November 2012 09:14:57 Simon Horman wrote:
> On Tue, Nov 20, 2012 at 01:45:20PM +0100, Laurent Pinchart wrote:
> > Hi Simon,
> >
> > Thank you for the patch.
> >
> > On Monday 19 November 2012 14:13:21 Simon Horman wrote:
> > > From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > >
> > > Cc: Magnus Damm <damm@opensource.se>
> > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> > > Signed-off-by: Simon Horman <horms@verge.net.au>
> >
> > I came up today with pretty much the same patch :-)
> >
> > > ---
> > >
> > > arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > > b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts index a7505a9..a8e7bd9
> > > 100644
> > > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> > > @@ -9,7 +9,7 @@
> > >
> > > */
> > >
> > > /dts-v1/;
> > >
> > > -/include/ "skeleton.dtsi"
> > > +/include/ "r8a7740.dtsi"
> > >
> > > / {
> > >
> > > model = "armadillo 800 eva";
> >
> > Shouldn't the compatible property be modified to the following values ?
> >
> > compatible = "renesas,armadillo800eva", "renesas,r8a7740";
>
> To be honest, I'm not sure.
> But as this is a dts file for a board "renesas,r8a7740" seems strange to me.
If I understand DT correctly, the goal is to get rid of the board file at some
point and only keep the generic r8a7740 board code. Shouldn't we then match on
"renesas,r8a7740" ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-11-21 1:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 5:13 [RFC 00/15 v4] shmobile DT initialisation of INTC and GIC Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 01/15] ARM: mach-shmobile: Add support OF for INTC of shmobile Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 02/15] SH: intc: Add support OF of IRQ Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 03/15] ARM: mach-shmobile: Add support OF of INTC for r8a7740 Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 04/15] ARM: mach-shmobile: Add support OF of INTC for sh73a0 Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 05/15] ARM: mach-shmobile: Add support OF of INTC for sh7372 Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 06/15] ARM: mach-shmobile: Add DT table of INTC for sh73a0 Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 07/15] ARM: mach-shmobile: Add DT table of INTC for sh7372 Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 08/15] ARM: mach-shmobile: Add DT table of INTC for r8a7740 Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 09/15] ARM: shmobile: Include DTSI of r8a7740 to armadillo800eva Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-20 12:45 ` Laurent Pinchart
2012-11-20 12:45 ` Laurent Pinchart
2012-11-21 0:14 ` Simon Horman
2012-11-21 0:14 ` Simon Horman
2012-11-21 1:03 ` Laurent Pinchart [this message]
2012-11-21 1:03 ` Laurent Pinchart
2012-11-21 1:29 ` Simon Horman
2012-11-21 1:29 ` Simon Horman
2012-11-19 5:13 ` [RFC 10/15] ARM: shmobile: Include DTSI of sh73a0 to kzm9g board Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 11/15] ARM: shmobile: kzm9g: Use DT initialisation of INTC Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 12/15] ARM: shmobile: r8a7740: " Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 13/15] ARM: shmobile: sh7372: " Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 14/15] ARM: shmobile: Add DT table of GIC for sh73a0 Simon Horman
2012-11-19 5:13 ` Simon Horman
2012-11-19 5:13 ` [RFC 15/15] ARM: shmobile: sh73a0: Use DT for GIC Simon Horman
2012-11-19 5:13 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19065301.iqf7oYnrtW@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.