All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Stimming <stimming@tuhh.de>
To: Ralf Thielow <ralf.thielow@gmail.com>
Cc: trast@student.ethz.ch, jk@jk.gs, git@vger.kernel.org
Subject: Re: [PATCH/RFC] l10n: de.po: translate 39 new messages
Date: Mon, 15 Apr 2013 21:26:44 +0200	[thread overview]
Message-ID: <1906942.3yyCMUNxTB@cs-pc> (raw)
In-Reply-To: <1366043260-3131-1-git-send-email-ralf.thielow@gmail.com>

Thanks for the regular update! This is great work.

One issue with the plural form messages, though:

Am Montag, 15. April 2013, 18:27:40 schrieb Ralf Thielow:
>  #: bundle.c:186
> -#, fuzzy, c-format
> +#, c-format
>  msgid "The bundle contains this ref:"
>  msgid_plural "The bundle contains these %d refs:"
> -msgstr[0] "Das Paket enthält %d Referenz"
> -msgstr[1] "Das Paket enthält %d Referenzen"
> +msgstr[0] "Das Paket enthält diese Referenz:"
> +msgstr[1] "Das Paket enthält diese %d Referenzen:"

The msgstr[0] must still contain a %d conversion specifier (which will be 
filled with the number 1) even though the translated sentence wouldn't need 
the 1 anymore. The previous msgstr[0] was correct; the English singular msgid 
is not.

Technical background: The ngettext function chooses only the string itself, 
which will then be fed to printf() as a second step. If the printf sees more 
variadic arguments than conversion specifiers in the string, it will be 
unhappy. At least that's what I remembered about the ngettext things...

http://www.gnu.org/software/libc/manual/html_node/Advanced-gettext-
functions.html

Regards,

Christian

  reply	other threads:[~2013-04-15 20:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 16:27 [PATCH/RFC] l10n: de.po: translate 39 new messages Ralf Thielow
2013-04-15 19:26 ` Christian Stimming [this message]
2013-04-17  5:18   ` Ralf Thielow
     [not found]   ` <CAN0XMOLmwUpwOi0xz4iOy3wfhzCeeNKNgywgS9ZfaET172vsBQ@mail.gmail.com>
2013-04-17  8:09     ` Thomas Rast
2013-04-17 15:35       ` Christian Stimming
2013-04-17 23:02   ` Junio C Hamano
2013-04-16  8:34 ` Thomas Rast
2013-04-17  5:49   ` Ralf Thielow
2013-04-17  7:50     ` Thomas Rast
2013-04-18 17:14 ` [PATCHv2] " Ralf Thielow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1906942.3yyCMUNxTB@cs-pc \
    --to=stimming@tuhh.de \
    --cc=git@vger.kernel.org \
    --cc=jk@jk.gs \
    --cc=ralf.thielow@gmail.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.