From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
Date: Thu, 06 Feb 2014 10:28:52 +0000 [thread overview]
Message-ID: <1910899.86Rh9nDz51@avalon> (raw)
In-Reply-To: <1391646301-20197-1-git-send-email-horms+renesas@verge.net.au>
Hi Simon,
Thank you for the patch.
On Thursday 06 February 2014 09:25:01 Simon Horman wrote:
> This brings the implementation into line with the documentation.
>
> This problem was introduced when SYS DMAC clock defines were added by
> ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
> sources") in v3.13-rc2. I do not believe this results in any problems as
> these defines do not appear to be used anywhere yet.
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/dt-bindings/clock/r8a7790-clock.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/r8a7790-clock.h
> b/include/dt-bindings/clock/r8a7790-clock.h index 859e9be..6548a5f 100644
> --- a/include/dt-bindings/clock/r8a7790-clock.h
> +++ b/include/dt-bindings/clock/r8a7790-clock.h
> @@ -46,8 +46,8 @@
> #define R8A7790_CLK_MSIOF1 8
> #define R8A7790_CLK_MSIOF3 15
> #define R8A7790_CLK_SCIFB2 16
> -#define R8A7790_CLK_SYS_DMAC0 18
> -#define R8A7790_CLK_SYS_DMAC1 19
> +#define R8A7790_CLK_SYS_DMAC1 18
> +#define R8A7790_CLK_SYS_DMAC0 19
>
> /* MSTP3 */
> #define R8A7790_CLK_TPU0 4
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines
Date: Thu, 06 Feb 2014 11:28:52 +0100 [thread overview]
Message-ID: <1910899.86Rh9nDz51@avalon> (raw)
In-Reply-To: <1391646301-20197-1-git-send-email-horms+renesas@verge.net.au>
Hi Simon,
Thank you for the patch.
On Thursday 06 February 2014 09:25:01 Simon Horman wrote:
> This brings the implementation into line with the documentation.
>
> This problem was introduced when SYS DMAC clock defines were added by
> ac991dce6498b5fc ("ARM: shmobile: r8a7790: Add clock index macros for DT
> sources") in v3.13-rc2. I do not believe this results in any problems as
> these defines do not appear to be used anywhere yet.
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/dt-bindings/clock/r8a7790-clock.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/r8a7790-clock.h
> b/include/dt-bindings/clock/r8a7790-clock.h index 859e9be..6548a5f 100644
> --- a/include/dt-bindings/clock/r8a7790-clock.h
> +++ b/include/dt-bindings/clock/r8a7790-clock.h
> @@ -46,8 +46,8 @@
> #define R8A7790_CLK_MSIOF1 8
> #define R8A7790_CLK_MSIOF3 15
> #define R8A7790_CLK_SCIFB2 16
> -#define R8A7790_CLK_SYS_DMAC0 18
> -#define R8A7790_CLK_SYS_DMAC1 19
> +#define R8A7790_CLK_SYS_DMAC1 18
> +#define R8A7790_CLK_SYS_DMAC0 19
>
> /* MSTP3 */
> #define R8A7790_CLK_TPU0 4
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-02-06 10:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 5:01 [PATCH] ARM: shmobile: r8a7790: Correct typo in clocks Simon Horman
2013-11-06 5:01 ` Simon Horman
2013-11-06 6:06 ` Kuninori Morimoto
2013-11-06 6:06 ` Kuninori Morimoto
2013-11-06 8:35 ` Simon Horman
2013-11-06 8:35 ` Simon Horman
2013-11-08 7:59 ` Simon Horman
2013-11-08 7:59 ` Simon Horman
2014-02-06 0:25 ` [PATCH] ARM: shmobile: r8a7790: Correct SYS DMAC clock defines Simon Horman
2014-02-06 0:25 ` Simon Horman
2014-02-06 10:28 ` Laurent Pinchart [this message]
2014-02-06 10:28 ` Laurent Pinchart
2014-02-07 0:24 ` Simon Horman
2014-02-07 0:24 ` Simon Horman
2014-02-10 12:22 ` Ben Dooks
2014-02-10 12:22 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1910899.86Rh9nDz51@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.