All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: daniel.vetter@ffwll.ch, tomi.valkeinen@ti.com,
	hoegsberg@gmail.com, abrodkin@synopsys.com,
	dri-devel@lists.freedesktop.org, liviu.dudau@arm.com,
	jsarha@ti.com
Subject: Re: [PATCH v4 09/11] drm/tilcdc: Use drm_gem_cma_print_info()
Date: Sat, 04 Nov 2017 09:56:04 +0200	[thread overview]
Message-ID: <19115272.VBCJqYLATJ@avalon> (raw)
In-Reply-To: <20171030162945.58063-10-noralf@tronnes.org>

Hi Noralf,

Thank you for the patch.

On Monday, 30 October 2017 18:29:43 EET Noralf Trønnes wrote:
> There is a new core debugfs file that prints fb/gem info:
> <debugfs>/dri/<n>/framebuffer
> 
> Use drm_gem_cma_print_info() to provide info to that output instead
> of using drm_fb_cma_debugfs_show().
> 
> Cc: Jyri Sarha <jsarha@ti.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 72ce063aa0d8..bc4feb3a84b9
> 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -507,7 +507,6 @@ static int tilcdc_mm_show(struct seq_file *m, void *arg)
> static struct drm_info_list tilcdc_debugfs_list[] = {
>  		{ "regs", tilcdc_regs_show, 0 },
>  		{ "mm",   tilcdc_mm_show,   0 },
> -		{ "fb",   drm_fb_cma_debugfs_show, 0 },
>  };
> 
>  static int tilcdc_debugfs_init(struct drm_minor *minor)
> @@ -541,6 +540,7 @@ static struct drm_driver tilcdc_driver = {
>  	.lastclose          = tilcdc_lastclose,
>  	.irq_handler        = tilcdc_irq,
>  	.gem_free_object_unlocked = drm_gem_cma_free_object,
> +	.gem_print_info     = drm_gem_cma_print_info,
>  	.gem_vm_ops         = &drm_gem_cma_vm_ops,
>  	.dumb_create        = drm_gem_cma_dumb_create,


-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-11-04  7:56 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-30 16:29 [PATCH v4 00/11] drm/framebuffer: Add framebuffer debugfs file Noralf Trønnes
2017-10-30 16:29 ` [PATCH v4 01/11] drm/vma-manager: drm_vma_node_start() constify argument Noralf Trønnes
2017-11-02  4:29   ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 02/11] drm/framebuffer: drm_framebuffer_read_refcount() " Noralf Trønnes
2017-11-02  4:30   ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 03/11] drm/print: Add drm_printf_indent() Noralf Trønnes
2017-11-02  4:32   ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 04/11] drm/framebuffer: Add framebuffer debugfs file Noralf Trønnes
2017-11-02  4:43   ` Laurent Pinchart
2017-11-02 14:12     ` Noralf Trønnes
2017-10-30 16:29 ` [PATCH v4 05/11] drm/atomic: Use drm_framebuffer_print_info() Noralf Trønnes
2017-11-02  4:44   ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 06/11] drm/cma-helper: Add drm_gem_cma_print_info() Noralf Trønnes
2017-11-04  7:54   ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 07/11] drm/arc: Use drm_gem_cma_print_info() Noralf Trønnes
2017-10-31 16:17   ` Alexey Brodkin
2017-10-31 18:15     ` Ville Syrjälä
2017-11-04  7:55   ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 08/11] drm/arm/hdlcd: " Noralf Trønnes
2017-10-31  9:49   ` Liviu Dudau
2017-11-04  7:55   ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 09/11] drm/tilcdc: " Noralf Trønnes
2017-10-31 15:09   ` Jyri Sarha
2017-11-04  7:56   ` Laurent Pinchart [this message]
2017-10-30 16:29 ` [PATCH v4 10/11] drm/tinydrm: " Noralf Trønnes
2017-11-04  7:56   ` Laurent Pinchart
2017-10-30 16:29 ` [PATCH v4 11/11] drm/cma-helper: Remove drm_fb_cma_debugfs_show() Noralf Trønnes
2017-10-31 10:35   ` Daniel Vetter
2017-11-04  7:58   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19115272.VBCJqYLATJ@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=abrodkin@synopsys.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hoegsberg@gmail.com \
    --cc=jsarha@ti.com \
    --cc=liviu.dudau@arm.com \
    --cc=noralf@tronnes.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.