Re: [PATCH v4 10/11] drm/tinydrm: Use drm_gem_cma_print_info()

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Noralf,

Thank you for the patch.

On Monday, 30 October 2017 18:29:44 EET Noralf Trønnes wrote:
> There is a new core debugfs file that prints fb/gem info:
> <debugfs>/dri/<n>/framebuffer
> 
> Use drm_gem_cma_print_info() to provide info to that output instead
> of using drm_fb_cma_debugfs_show().
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/tinydrm/mipi-dbi.c | 8 +-------
>  include/drm/tinydrm/tinydrm.h      | 1 +
>  2 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c
> b/drivers/gpu/drm/tinydrm/mipi-dbi.c index d43e992ab432..347f9b226f26
> 100644
> --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c
> +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c
> @@ -961,10 +961,6 @@ static const struct file_operations
> mipi_dbi_debugfs_command_fops = { .write = mipi_dbi_debugfs_command_write,
>  };
> 
> -static const struct drm_info_list mipi_dbi_debugfs_list[] = {
> -	{ "fb",   drm_fb_cma_debugfs_show, 0 },
> -};
> -
>  /**
>   * mipi_dbi_debugfs_init - Create debugfs entries
>   * @minor: DRM minor
> @@ -987,9 +983,7 @@ int mipi_dbi_debugfs_init(struct drm_minor *minor)
>  	debugfs_create_file("command", mode, minor->debugfs_root, mipi,
>  			    &mipi_dbi_debugfs_command_fops);
> 
> -	return drm_debugfs_create_files(mipi_dbi_debugfs_list,
> -					ARRAY_SIZE(mipi_dbi_debugfs_list),
> -					minor->debugfs_root, minor);
> +	return 0;
>  }
>  EXPORT_SYMBOL(mipi_dbi_debugfs_init);
> 
> diff --git a/include/drm/tinydrm/tinydrm.h b/include/drm/tinydrm/tinydrm.h
> index 4774fe3d4273..423828922e5a 100644
> --- a/include/drm/tinydrm/tinydrm.h
> +++ b/include/drm/tinydrm/tinydrm.h
> @@ -46,6 +46,7 @@ pipe_to_tinydrm(struct drm_simple_display_pipe *pipe)
>   */
>  #define TINYDRM_GEM_DRIVER_OPS \
>  	.gem_free_object	= tinydrm_gem_cma_free_object, \
> +	.gem_print_info		= drm_gem_cma_print_info, \
>  	.gem_vm_ops		= &drm_gem_cma_vm_ops, \
>  	.prime_handle_to_fd	= drm_gem_prime_handle_to_fd, \
>  	.prime_fd_to_handle	= drm_gem_prime_fd_to_handle, \


-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel