[LTP] [PATCH] diotest3: fix -f argument

[LTP] [PATCH] diotest3: fix -f argument

[Jeff Layton]

The '-f' argument to diotest3 is currently ignored. During options
processing it's copied to the buffer, then subsequently overwritten
by the default in a later sprintf() call.

Move the setting of the default prior to the options processing.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 testcases/kernel/io/direct_io/diotest3.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/io/direct_io/diotest3.c b/testcases/kernel/io/direct_io/diotest3.c
index ac460ed..002a6d0 100644
--- a/testcases/kernel/io/direct_io/diotest3.c
+++ b/testcases/kernel/io/direct_io/diotest3.c
@@ -238,6 +238,8 @@ int main(int argc, char *argv[])
 	int numchild = 1;	/* Number of children. Default 5 */
 	int i, fail_count = 0, failed = 0, total = 0;
 
+	sprintf(filename, "testdata-3.%ld", syscall(__NR_gettid));
+
 	/* Options */
 	while ((i = getopt(argc, argv, "b:o:i:n:f:")) != -1) {
 		switch (i) {
@@ -277,7 +279,6 @@ int main(int argc, char *argv[])
 			prg_usage();
 		}
 	}
-	sprintf(filename, "testdata-3.%ld", syscall(__NR_gettid));
 
 	setup();
 
-- 
1.7.1


------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] diotest3: fix -f argument

[Jan Stancek]

----- Original Message -----
> From: "Jeff Layton" <jlayton@redhat.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Wednesday, 6 November, 2013 5:39:11 PM
> Subject: [LTP] [PATCH] diotest3: fix -f argument
> 
> The '-f' argument to diotest3 is currently ignored. During options
> processing it's copied to the buffer, then subsequently overwritten
> by the default in a later sprintf() call.
> 
> Move the setting of the default prior to the options processing.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Hi Jeff,

pushed. I checked also other diotest*.c, but diotest3.c
was the only one having this issue.

Thanks,
Jan

> ---
>  testcases/kernel/io/direct_io/diotest3.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/testcases/kernel/io/direct_io/diotest3.c
> b/testcases/kernel/io/direct_io/diotest3.c
> index ac460ed..002a6d0 100644
> --- a/testcases/kernel/io/direct_io/diotest3.c
> +++ b/testcases/kernel/io/direct_io/diotest3.c
> @@ -238,6 +238,8 @@ int main(int argc, char *argv[])
>  	int numchild = 1;	/* Number of children. Default 5 */
>  	int i, fail_count = 0, failed = 0, total = 0;
>  
> +	sprintf(filename, "testdata-3.%ld", syscall(__NR_gettid));
> +
>  	/* Options */
>  	while ((i = getopt(argc, argv, "b:o:i:n:f:")) != -1) {
>  		switch (i) {
> @@ -277,7 +279,6 @@ int main(int argc, char *argv[])
>  			prg_usage();
>  		}
>  	}
> -	sprintf(filename, "testdata-3.%ld", syscall(__NR_gettid));
>  
>  	setup();
>  
> --
> 1.7.1
> 
> 
> ------------------------------------------------------------------------------
> November Webinars for C, C++, Fortran Developers
> Accelerate application performance with scalable programming models. Explore
> techniques for threading, error checking, porting, and tuning. Get the most
> from the latest Intel processors and coprocessors. See abstracts and register
> http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] diotest3: fix -f argument

[Jeff Layton]

On Wed, 6 Nov 2013 16:34:58 -0500 (EST)
Jan Stancek <jstancek@redhat.com> wrote:

> 
> 
> 
> 
> ----- Original Message -----
> > From: "Jeff Layton" <jlayton@redhat.com>
> > To: ltp-list@lists.sourceforge.net
> > Sent: Wednesday, 6 November, 2013 5:39:11 PM
> > Subject: [LTP] [PATCH] diotest3: fix -f argument
> > 
> > The '-f' argument to diotest3 is currently ignored. During options
> > processing it's copied to the buffer, then subsequently overwritten
> > by the default in a later sprintf() call.
> > 
> > Move the setting of the default prior to the options processing.
> > 
> > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> 
> Hi Jeff,
> 
> pushed. I checked also other diotest*.c, but diotest3.c
> was the only one having this issue.
> 
> Thanks,
> Jan
> 

Thanks, that's what I found too. The only other (minor) problem I see
is that the LEN value used in all of the diotests to size the buffer
for the filename is pitifully small. It might be reasonable to get rid
of that and just use PATH_MAX...

> > ---
> >  testcases/kernel/io/direct_io/diotest3.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/testcases/kernel/io/direct_io/diotest3.c
> > b/testcases/kernel/io/direct_io/diotest3.c
> > index ac460ed..002a6d0 100644
> > --- a/testcases/kernel/io/direct_io/diotest3.c
> > +++ b/testcases/kernel/io/direct_io/diotest3.c
> > @@ -238,6 +238,8 @@ int main(int argc, char *argv[])
> >  	int numchild = 1;	/* Number of children. Default 5 */
> >  	int i, fail_count = 0, failed = 0, total = 0;
> >  
> > +	sprintf(filename, "testdata-3.%ld", syscall(__NR_gettid));
> > +
> >  	/* Options */
> >  	while ((i = getopt(argc, argv, "b:o:i:n:f:")) != -1) {
> >  		switch (i) {
> > @@ -277,7 +279,6 @@ int main(int argc, char *argv[])
> >  			prg_usage();
> >  		}
> >  	}
> > -	sprintf(filename, "testdata-3.%ld", syscall(__NR_gettid));
> >  
> >  	setup();
> >  
> > --
> > 1.7.1
> > 
> > 
> > ------------------------------------------------------------------------------
> > November Webinars for C, C++, Fortran Developers
> > Accelerate application performance with scalable programming models. Explore
> > techniques for threading, error checking, porting, and tuning. Get the most
> > from the latest Intel processors and coprocessors. See abstracts and register
> > http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp-list@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
> > 


-- 
Jeff Layton <jlayton@redhat.com>

------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list