All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Elaine Zhang <zhangqing@rock-chips.com>
Cc: mturquette@baylibre.com, sboyd@codeaurora.org, xf@rock-chips.com,
	rocky.hao@rock-chips.com, huangtao@rock-chips.com,
	xxx@rock-chips.com, jay.xu@rock-chips.com,
	linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: rockchip: validity should be checked prior to clock rate change
Date: Tue, 08 Nov 2016 14:26:54 +0100	[thread overview]
Message-ID: <1924809.LJTn50YVYo@diego> (raw)
In-Reply-To: <1478596214-761-1-git-send-email-zhangqing@rock-chips.com>

Hi Elaine,

Am Dienstag, 8. November 2016, 17:10:14 schrieb Elaine Zhang:
> If validity is not checked prior to clock rate change, clk_set_rate(
> cpu_clk, unsupported_rate) will return success, but the real clock rate
> change operation is prohibited in post clock change event. Alough post
> clock change event will report error due to unsupported clock rate is
> set, but this error message is ignored by clock framework.
> 
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Rocky Hao <rocky.hao@rock-chips.com>

looks good and thanks for catching this. Just a bureaucracy-question regarding 
the Signed-off-by lines, before I can apply the patch as I don't really know 
how Rocky fits into the picture.

I.e. was he the original patch author (the we should change the from) or a 
reviewer/tester for the fixed issue?


Thanks
Heiko

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	xf-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
	sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	rocky.hao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	xxx-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH] clk: rockchip: validity should be checked prior to clock rate change
Date: Tue, 08 Nov 2016 14:26:54 +0100	[thread overview]
Message-ID: <1924809.LJTn50YVYo@diego> (raw)
In-Reply-To: <1478596214-761-1-git-send-email-zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Hi Elaine,

Am Dienstag, 8. November 2016, 17:10:14 schrieb Elaine Zhang:
> If validity is not checked prior to clock rate change, clk_set_rate(
> cpu_clk, unsupported_rate) will return success, but the real clock rate
> change operation is prohibited in post clock change event. Alough post
> clock change event will report error due to unsupported clock rate is
> set, but this error message is ignored by clock framework.
> 
> Signed-off-by: Elaine Zhang <zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Signed-off-by: Rocky Hao <rocky.hao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

looks good and thanks for catching this. Just a bureaucracy-question regarding 
the Signed-off-by lines, before I can apply the patch as I don't really know 
how Rocky fits into the picture.

I.e. was he the original patch author (the we should change the from) or a 
reviewer/tester for the fixed issue?


Thanks
Heiko

  reply	other threads:[~2016-11-08 13:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08  9:10 [PATCH] clk: rockchip: validity should be checked prior to clock rate change Elaine Zhang
2016-11-08  9:10 ` Elaine Zhang
2016-11-08 13:26 ` Heiko Stübner [this message]
2016-11-08 13:26   ` Heiko Stübner
2016-11-14 16:41 ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1924809.LJTn50YVYo@diego \
    --to=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=jay.xu@rock-chips.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=rocky.hao@rock-chips.com \
    --cc=sboyd@codeaurora.org \
    --cc=xf@rock-chips.com \
    --cc=xxx@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.