From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: mareklindner@neomailbox.ch, netdev@vger.kernel.org,
a@unstable.cc, fgao@ikuai8.com, gfree.wind@gmail.com,
davem@davemloft.net
Subject: Re: [B.A.T.M.A.N.] [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully
Date: Mon, 21 Nov 2016 09:16:29 +0100 [thread overview]
Message-ID: <1926952.1nDu9mPud9@bentobox> (raw)
In-Reply-To: <1479688779-1328-1-git-send-email-fgao@ikuai8.com>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On Montag, 21. November 2016 08:39:39 CET fgao@ikuai8.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> The tc could return NET_XMIT_CN as one congestion notification, but
> it does not mean the packe is lost. Other modules like ipvlan,
s/packe/packet/
> macvlan, and others treat NET_XMIT_CN as success too.
>
> So batman-adv should add the NET_XMIT_CN check.
>
> Signed-off-by: Gao Feng <fgao@ikuai8.com>
> ---
> net/batman-adv/distributed-arp-table.c | 2 +-
> net/batman-adv/fragmentation.c | 2 +-
> net/batman-adv/routing.c | 2 +-
> net/batman-adv/tp_meter.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
[...]
Not sure how the batman-adv maintainers see this - but this patch needs
an additional patch for net-next to also add it to the parts which were
rewritten.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: fgao@ikuai8.com, mareklindner@neomailbox.ch,
sw@simonwunderlich.de, a@unstable.cc, davem@davemloft.net,
netdev@vger.kernel.org, gfree.wind@gmail.com
Subject: Re: [B.A.T.M.A.N.] [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully
Date: Mon, 21 Nov 2016 09:16:29 +0100 [thread overview]
Message-ID: <1926952.1nDu9mPud9@bentobox> (raw)
In-Reply-To: <1479688779-1328-1-git-send-email-fgao@ikuai8.com>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On Montag, 21. November 2016 08:39:39 CET fgao@ikuai8.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> The tc could return NET_XMIT_CN as one congestion notification, but
> it does not mean the packe is lost. Other modules like ipvlan,
s/packe/packet/
> macvlan, and others treat NET_XMIT_CN as success too.
>
> So batman-adv should add the NET_XMIT_CN check.
>
> Signed-off-by: Gao Feng <fgao@ikuai8.com>
> ---
> net/batman-adv/distributed-arp-table.c | 2 +-
> net/batman-adv/fragmentation.c | 2 +-
> net/batman-adv/routing.c | 2 +-
> net/batman-adv/tp_meter.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
[...]
Not sure how the batman-adv maintainers see this - but this patch needs
an additional patch for net-next to also add it to the parts which were
rewritten.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-11-21 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 0:39 [B.A.T.M.A.N.] [PATCH net 1/1] net: batman-adv: Treat NET_XMIT_CN as transmit successfully fgao
2016-11-21 0:39 ` fgao
2016-11-21 8:16 ` Sven Eckelmann [this message]
2016-11-21 8:16 ` [B.A.T.M.A.N.] " Sven Eckelmann
2016-11-21 8:21 ` Feng Gao
2016-11-21 8:21 ` Feng Gao
2016-11-21 8:31 ` Sven Eckelmann
2016-11-21 8:31 ` Sven Eckelmann
2016-11-21 8:47 ` [B.A.T.M.A.N.] " Feng Gao
2016-11-21 8:47 ` Feng Gao
2016-11-21 10:44 ` [B.A.T.M.A.N.] " Sergei Shtylyov
2016-11-21 10:44 ` Sergei Shtylyov
2016-11-21 11:01 ` [B.A.T.M.A.N.] " Feng Gao
2016-11-21 11:01 ` Feng Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1926952.1nDu9mPud9@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.