All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com,
	david.marchand@6wind.com
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal:Change log output to DEBUG instead of INFO
Date: Fri, 12 Feb 2016 18:56:49 +0100	[thread overview]
Message-ID: <1928276.P2Lqin6BEp@xps13> (raw)
In-Reply-To: <1441914050-43168-1-git-send-email-keith.wiles@intel.com>

Sergio, Anatoly, David,
It is not so obvious to decide the log level. Please comment or ack.

2015-09-10 14:40, Keith Wiles:
> When log level is set to 7 (INFO) these messages are still displayed
> and should be set to DEBUG.
> 
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
>  lib/librte_eal/common/eal_common_memory.c  | 2 +-
>  lib/librte_eal/common/eal_common_timer.c   | 2 +-
>  lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
> index b647573..6155752 100644
> --- a/lib/librte_eal/common/eal_common_memory.c
> +++ b/lib/librte_eal/common/eal_common_memory.c
> @@ -139,7 +139,7 @@ rte_eal_memdevice_init(void)
>  int
>  rte_eal_memory_init(void)
>  {
> -	RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n");
> +	RTE_LOG(DEBUG, EAL, "Setting up physically contiguous memory...\n");
>  
>  	const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ?
>  			rte_eal_hugepage_init() :
> diff --git a/lib/librte_eal/common/eal_common_timer.c b/lib/librte_eal/common/eal_common_timer.c
> index 72371b8..c4227cd 100644
> --- a/lib/librte_eal/common/eal_common_timer.c
> +++ b/lib/librte_eal/common/eal_common_timer.c
> @@ -81,6 +81,6 @@ set_tsc_freq(void)
>  	if (!freq)
>  		freq = estimate_tsc_freq();
>  
> -	RTE_LOG(INFO, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
> +	RTE_LOG(DEBUG, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000);
>  	eal_tsc_resolution_hz = freq;
>  }
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> index 0e6c48a..e0c13de 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> @@ -904,7 +904,7 @@ pci_vfio_enable(void)
>  
>  	/* return 0 if VFIO modules not loaded */
>  	if (module_vfio_type1 == 0) {
> -		RTE_LOG(INFO, EAL, "VFIO modules not all loaded, "
> +		RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, "
>  			"skip VFIO support...\n");
>  		return 0;
>  	}
> 

  reply	other threads:[~2016-02-12 17:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 19:40 [PATCH] eal:Change log output to DEBUG instead of INFO Keith Wiles
2016-02-12 17:56 ` Thomas Monjalon [this message]
2016-02-18 10:18   ` Burakov, Anatoly
2016-02-18 14:08     ` Thomas Monjalon
2016-02-18 14:38       ` Burakov, Anatoly
2016-03-13 22:36 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1928276.P2Lqin6BEp@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=anatoly.burakov@intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.