All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	kernel@pengutronix.de,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP
Date: Tue, 24 Sep 2024 11:31:45 +0200	[thread overview]
Message-ID: <1931378.eGJsNajkDb@phil> (raw)
In-Reply-To: <a4b3c8c1cca9515e67adac83af5ba1b1fab2fcbc.1727169288.git.geert+renesas@glider.be>

Am Dienstag, 24. September 2024, 11:15:31 CEST schrieb Geert Uytterhoeven:
> The Rockchip CAN-FD controller is only present on Rockchip SoCs.  Hence
> add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this
> driver when configuring a kernel without Rockchip platform support.
> 
> Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

makes a lot of sense, and with the compile-test in, it'll still get
test-build

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/net/can/rockchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/can/rockchip/Kconfig b/drivers/net/can/rockchip/Kconfig
> index e029e2a3ca4b04df..fd8d9f5eeaa434ac 100644
> --- a/drivers/net/can/rockchip/Kconfig
> +++ b/drivers/net/can/rockchip/Kconfig
> @@ -3,6 +3,7 @@
>  config CAN_ROCKCHIP_CANFD
>  	tristate "Rockchip CAN-FD controller"
>  	depends on OF || COMPILE_TEST
> +	depends on ARCH_ROCKCHIP || COMPILE_TEST
>  	select CAN_RX_OFFLOAD
>  	help
>  	  Say Y here if you want to use CAN-FD controller found on
> 





WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	kernel@pengutronix.de,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP
Date: Tue, 24 Sep 2024 11:31:45 +0200	[thread overview]
Message-ID: <1931378.eGJsNajkDb@phil> (raw)
In-Reply-To: <a4b3c8c1cca9515e67adac83af5ba1b1fab2fcbc.1727169288.git.geert+renesas@glider.be>

Am Dienstag, 24. September 2024, 11:15:31 CEST schrieb Geert Uytterhoeven:
> The Rockchip CAN-FD controller is only present on Rockchip SoCs.  Hence
> add a dependency on ARCH_ROCKCHIP, to prevent asking the user about this
> driver when configuring a kernel without Rockchip platform support.
> 
> Fixes: ff60bfbaf67f219c ("can: rockchip_canfd: add driver for Rockchip CAN-FD controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

makes a lot of sense, and with the compile-test in, it'll still get
test-build

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/net/can/rockchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/can/rockchip/Kconfig b/drivers/net/can/rockchip/Kconfig
> index e029e2a3ca4b04df..fd8d9f5eeaa434ac 100644
> --- a/drivers/net/can/rockchip/Kconfig
> +++ b/drivers/net/can/rockchip/Kconfig
> @@ -3,6 +3,7 @@
>  config CAN_ROCKCHIP_CANFD
>  	tristate "Rockchip CAN-FD controller"
>  	depends on OF || COMPILE_TEST
> +	depends on ARCH_ROCKCHIP || COMPILE_TEST
>  	select CAN_RX_OFFLOAD
>  	help
>  	  Say Y here if you want to use CAN-FD controller found on
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2024-09-24  9:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-24  9:15 [PATCH] can: CAN_ROCKCHIP_CANFD should depend on ARCH_ROCKCHIP Geert Uytterhoeven
2024-09-24  9:15 ` Geert Uytterhoeven
2024-09-24  9:31 ` Heiko Stuebner [this message]
2024-09-24  9:31   ` Heiko Stuebner
2024-09-24 12:16 ` Marc Kleine-Budde
2024-09-24 12:16   ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1931378.eGJsNajkDb@phil \
    --to=heiko@sntech.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=geert+renesas@glider.be \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.