All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: horms@verge.net.au, linux-renesas-soc@vger.kernel.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, magnus.damm@gmail.com,
	linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: r8a7794: link DU to VSPD
Date: Tue, 03 Jan 2017 11:24:15 +0200	[thread overview]
Message-ID: <1931710.8mMFQrpegP@avalon> (raw)
In-Reply-To: <1524349.7vYNCWaVjE@wasted.cogentembedded.com>

Hi Sergei,

On Thursday 29 Dec 2016 00:35:07 Sergei Shtylyov wrote:
> Add the "vsps" property to the DU device node in order to link this node to
> the (single) VSPD node.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

I'd like to first address the issues I've pointed out on the driver side of 
this change.

> ---
> This patch is against the 'renesas-devel-20161220-v4.9' of Simon Horman's
> 'renesas.git' repo.  It's  only meaningful if the "Enable R8A7794 DU VSPD
> compositor" DU driver patches are applied...
> 
>  arch/arm/boot/dts/r8a7794.dtsi |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -908,7 +908,7 @@
>  		power-domains = <&sysc R8A7794_PD_ALWAYS_ON>;
>  	};
> 
> -	vsp1@fe930000 {
> +	vspd0: vsp1@fe930000 {
>  		compatible = "renesas,vsp1";
>  		reg = <0 0xfe930000 0 0x8000>;
>  		interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
> @@ -925,6 +925,7 @@
>  		clocks = <&mstp7_clks R8A7794_CLK_DU0>,
>  			 <&mstp7_clks R8A7794_CLK_DU0>;
>  		clock-names = "du.0", "du.1";
> +		vsps = <&vspd0>;
>  		status = "disabled";
> 
>  		ports {

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: r8a7794: link DU to VSPD
Date: Tue, 03 Jan 2017 11:24:15 +0200	[thread overview]
Message-ID: <1931710.8mMFQrpegP@avalon> (raw)
In-Reply-To: <1524349.7vYNCWaVjE@wasted.cogentembedded.com>

Hi Sergei,

On Thursday 29 Dec 2016 00:35:07 Sergei Shtylyov wrote:
> Add the "vsps" property to the DU device node in order to link this node to
> the (single) VSPD node.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

I'd like to first address the issues I've pointed out on the driver side of 
this change.

> ---
> This patch is against the 'renesas-devel-20161220-v4.9' of Simon Horman's
> 'renesas.git' repo.  It's  only meaningful if the "Enable R8A7794 DU VSPD
> compositor" DU driver patches are applied...
> 
>  arch/arm/boot/dts/r8a7794.dtsi |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -908,7 +908,7 @@
>  		power-domains = <&sysc R8A7794_PD_ALWAYS_ON>;
>  	};
> 
> -	vsp1 at fe930000 {
> +	vspd0: vsp1 at fe930000 {
>  		compatible = "renesas,vsp1";
>  		reg = <0 0xfe930000 0 0x8000>;
>  		interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
> @@ -925,6 +925,7 @@
>  		clocks = <&mstp7_clks R8A7794_CLK_DU0>,
>  			 <&mstp7_clks R8A7794_CLK_DU0>;
>  		clock-names = "du.0", "du.1";
> +		vsps = <&vspd0>;
>  		status = "disabled";
> 
>  		ports {

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2017-01-03  9:24 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 21:50 [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
2016-07-11 21:50 ` Sergei Shtylyov
2016-07-11 21:51 ` [PATCH 1/2] ARM: dts: r8a7792: add PLL1 divided by 2 clock Sergei Shtylyov
2016-07-11 21:51   ` Sergei Shtylyov
2016-07-11 21:51   ` Sergei Shtylyov
2016-07-13  1:20   ` Geert Uytterhoeven
2016-07-13  1:20     ` Geert Uytterhoeven
2016-07-13  1:20     ` Geert Uytterhoeven
2016-07-11 21:52 ` [PATCH 2/2] ARM: dts: r8a7792: remove ADSP clock Sergei Shtylyov
2016-07-11 21:52   ` Sergei Shtylyov
2016-07-13  1:23   ` Geert Uytterhoeven
2016-07-13  1:23     ` Geert Uytterhoeven
2016-07-12 20:30 ` [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
2016-07-12 20:30   ` Sergei Shtylyov
2016-07-15  4:25   ` Simon Horman
2016-07-15  4:25     ` Simon Horman
2016-10-29 21:31 ` [PATCH] ARM: dts: r8a7794: remove Z clock Sergei Shtylyov
2016-10-29 21:31   ` Sergei Shtylyov
2016-10-29 21:31   ` Sergei Shtylyov
2016-11-01  9:21   ` Simon Horman
2016-11-01  9:21     ` Simon Horman
2016-11-02  8:50   ` Geert Uytterhoeven
2016-11-02  8:50     ` Geert Uytterhoeven
2016-12-14 22:07 ` [PATCH] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
2016-12-14 22:07   ` Sergei Shtylyov
2016-12-14 22:07   ` Sergei Shtylyov
2016-12-15  9:59   ` Magnus Damm
2016-12-15  9:59     ` Magnus Damm
2016-12-15  9:59     ` Magnus Damm
2017-01-03  9:24   ` Laurent Pinchart
2017-01-03  9:24     ` Laurent Pinchart
2016-12-28 21:35 ` [PATCH] ARM: dts: r8a7794: link DU to VSPD Sergei Shtylyov
2016-12-28 21:35   ` Sergei Shtylyov
2016-12-28 21:35   ` Sergei Shtylyov
2017-01-03  9:24   ` Laurent Pinchart [this message]
2017-01-03  9:24     ` Laurent Pinchart
2017-01-25 21:42 ` [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
2017-01-25 21:42   ` Sergei Shtylyov
2017-01-26 18:42   ` Sergei Shtylyov
2017-01-26 18:42     ` Sergei Shtylyov
2017-02-01 11:13     ` Magnus Damm
2017-02-01 11:13       ` Magnus Damm
2017-02-01 11:40       ` Sergei Shtylyov
2017-02-01 11:40         ` Sergei Shtylyov
2017-02-01 12:01         ` Magnus Damm
2017-02-01 12:01           ` Magnus Damm
2017-02-01 12:01           ` Magnus Damm
2017-02-02 13:02           ` Sergei Shtylyov
2017-02-02 13:02             ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1931710.8mMFQrpegP@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.