Re: [OE-core] [PATCH RFC walnascar 1/3] systemd: enable getty generator by default

[ChenQi <Qi.Chen@windriver.com>]

With this patchset, the effect of serial-getty-generator PACKAGECONFIG 
is to control whether to remove systemd-getty-generator or not. But is 
there any case we want to remove this generator? If not, I think we 
should just remove this PACKAGECONFIG.

Regards,
Qi

On 4/23/25 03:00, Ross Burton via lists.openembedded.org wrote:
> Until recently, even when the getty generator was disabled in the
> systemd recipe it was actually still active.  This was because the old
> behaviour was to delete the serial-getty template unit if the generator
> was disabled, but the systemd-serialgetty package shipped then shipped
> the same files so the generator continued to run.  This was a bug in the
> original commit[1] so this behaviour has been present since 2016.
>
> My recent fixes[2] changed this: if the getty generator was disabled
> then the generator itself is deleted. This makes the actual behaviour
> match the intention, but the consequence was to demonstrate that some
> modern platforms were relying on this unexpected behaviour: specifically
> the genericarm64 BSP which intends to support a number of virtual and
> physical boards with a number of serial console ports that are not
> really suitable to be hardcoded into SERIAL_CONSOLES:
>
> - ttyS0
> - ttyAMA0 (AMBA PL011 uart)
> - ttyS2 (BeagleBone Play, S0 and S1 are internal)
> - hvc0 (KVM)
> - ttyPS1 (AMD KV260)
> - And most likely more
>
> Restore the existing behaviour by explicitly enabling the serial getty
> generator: this means that systemd will automatically bring up a getty
> on the first serial console it finds.
>
> In the future we should extend some level of dynamic console-finding to
> sysvinit-based systems by searching for a console device in inittab, but
> for now this reverts the unintentional regression.
>
> [1] oe-core 2a8d0df47c9 ("systemd: make systemd-serialgetty optional")
> [2] oe-core 2beb3170af6 ("systemd: if getty generator is disabled remove
>      the generator, not the units")
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>   meta/recipes-core/systemd/systemd_257.4.bb | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd_257.4.bb b/meta/recipes-core/systemd/systemd_257.4.bb
> index 64fb8fe69ac..f90308f0db0 100644
> --- a/meta/recipes-core/systemd/systemd_257.4.bb
> +++ b/meta/recipes-core/systemd/systemd_257.4.bb
> @@ -92,6 +92,7 @@ PACKAGECONFIG ??= " \
>       quotacheck \
>       randomseed \
>       resolved \
> +    serial-getty-generator \
>       set-time-epoch \
>       sysusers \
>       timedated \
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#215242): https://lists.openembedded.org/g/openembedded-core/message/215242
> Mute This Topic: https://lists.openembedded.org/mt/112401496/7304865
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [Qi.Chen@eng.windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>