All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Burton <ross.burton@arm.com>
To: openembedded-core@lists.openembedded.org
Cc: mikko.rapeli@linaro.org, bill.mills@linaro.org
Subject: [PATCH RFC walnascar 2/3] systemd: always depend on the explicit serial console units
Date: Tue, 22 Apr 2025 20:00:52 +0100	[thread overview]
Message-ID: <20250422190053.3244331-2-ross.burton@arm.com> (raw)
In-Reply-To: <20250422190053.3244331-1-ross.burton@arm.com>

The systemd-serialgetty recipe generates explicit units for consoles
that are defined in SERIAL_CONSOLES, and if that variable is not defined
then just produces an empty package.

Even when systemd has been configured to use the getty generator, if
there are explicit consoles defined then we should respect them.  Don't
conditionalise the dependency on systemd-serialgetty so that we always
pull in the explicit consoles.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-core/systemd/systemd_257.4.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/systemd/systemd_257.4.bb b/meta/recipes-core/systemd/systemd_257.4.bb
index f90308f0db0..5865c017e89 100644
--- a/meta/recipes-core/systemd/systemd_257.4.bb
+++ b/meta/recipes-core/systemd/systemd_257.4.bb
@@ -754,7 +754,7 @@ FILES:${PN} = " ${base_bindir}/* \
 FILES:${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
 
 RDEPENDS:${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) systemd-udev-rules util-linux-agetty util-linux-fsck util-linux-swaponoff util-linux-mkswap"
-RDEPENDS:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', '', 'systemd-serialgetty', d)}"
+RDEPENDS:${PN} += "systemd-serialgetty"
 RDEPENDS:${PN} += "volatile-binds"
 
 RRECOMMENDS:${PN} += "${PN}-extra-utils \
-- 
2.43.0



  reply	other threads:[~2025-04-22 19:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 19:00 [PATCH RFC walnascar 1/3] systemd: enable getty generator by default Ross Burton
2025-04-22 19:00 ` Ross Burton [this message]
2025-04-23 11:18   ` [PATCH RFC walnascar 2/3] systemd: always depend on the explicit serial console units Mikko Rapeli
2025-04-23 14:06     ` Ross Burton
     [not found]   ` <1838EE88B5ED2807.22956@lists.openembedded.org>
2025-04-23 13:33     ` [OE-core] " Mikko Rapeli
2025-04-22 19:00 ` [PATCH RFC walnascar 3/3] genericarm64: add ttyPS1 for KV260 Ross Burton
2025-04-23 10:24   ` Mikko Rapeli
2025-04-23 10:26     ` Ross Burton
2025-04-23  1:44 ` [OE-core] [PATCH RFC walnascar 1/3] systemd: enable getty generator by default ChenQi
2025-04-23 10:18 ` Mikko Rapeli
2025-04-23 10:40   ` Ross Burton
2025-04-23 10:55     ` Mikko Rapeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422190053.3244331-2-ross.burton@arm.com \
    --to=ross.burton@arm.com \
    --cc=bill.mills@linaro.org \
    --cc=mikko.rapeli@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.