* [PATCH 1/1] ARM: dts: Re-organize RTC status for 5420
@ 2013-12-19 10:57 Sachin Kamat
2013-12-20 21:12 ` Tomasz Figa
0 siblings, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2013-12-19 10:57 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: kgene.kim, sachin.kamat
Some boards might not have RTC xtal, so RTC shouldn't really be
enabled by default. Enable it in the required board files.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++
arch/arm/boot/dts/exynos5420.dtsi | 2 +-
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index 9f3a3231158b..090117d595cb 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -38,6 +38,10 @@
};
};
+ rtc@101E0000 {
+ status = "okay";
+ };
+
mmc@12200000 {
status = "okay";
broken-cd;
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 62e1ebe4e989..edb4926f17d6 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -31,6 +31,10 @@
};
};
+ rtc@101E0000 {
+ status = "okay";
+ };
+
mmc@12200000 {
status = "okay";
broken-cd;
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 1c1a6a0db252..0b4bb87ae5f9 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -271,7 +271,7 @@
rtc@101E0000 {
clocks = <&clock 317>;
clock-names = "rtc";
- status = "okay";
+ status = "disabled";
};
amba {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Re-organize RTC status for 5420
2013-12-19 10:57 [PATCH 1/1] ARM: dts: Re-organize RTC status for 5420 Sachin Kamat
@ 2013-12-20 21:12 ` Tomasz Figa
2013-12-21 4:05 ` Sachin Kamat
2014-01-03 10:08 ` Sachin Kamat
0 siblings, 2 replies; 5+ messages in thread
From: Tomasz Figa @ 2013-12-20 21:12 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-samsung-soc, kgene.kim
Hi Sachin,
On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote:
> Some boards might not have RTC xtal, so RTC shouldn't really be
> enabled by default. Enable it in the required board files.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++
> arch/arm/boot/dts/exynos5420.dtsi | 2 +-
> 3 files changed, 9 insertions(+), 1 deletion(-)
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
By the way, can we expect a patch like this for Exynos 5250 to make all
Exynos SoCs consistent about this?
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Re-organize RTC status for 5420
2013-12-20 21:12 ` Tomasz Figa
@ 2013-12-21 4:05 ` Sachin Kamat
2014-01-03 10:08 ` Sachin Kamat
1 sibling, 0 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-12-21 4:05 UTC (permalink / raw)
To: Tomasz Figa; +Cc: linux-samsung-soc, Kukjin Kim
Hi Tomasz,
On 21 December 2013 02:42, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Sachin,
>
> On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote:
>> Some boards might not have RTC xtal, so RTC shouldn't really be
>> enabled by default. Enable it in the required board files.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++
>> arch/arm/boot/dts/exynos5420.dtsi | 2 +-
>> 3 files changed, 9 insertions(+), 1 deletion(-)
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Thanks.
>
> By the way, can we expect a patch like this for Exynos 5250 to make all
> Exynos SoCs consistent about this?
Sure. That was my plan.
---
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Re-organize RTC status for 5420
2013-12-20 21:12 ` Tomasz Figa
2013-12-21 4:05 ` Sachin Kamat
@ 2014-01-03 10:08 ` Sachin Kamat
2014-02-24 0:19 ` Kukjin Kim
1 sibling, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2014-01-03 10:08 UTC (permalink / raw)
To: Kukjin Kim; +Cc: linux-samsung-soc, Kukjin Kim
On 21 December 2013 02:42, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Sachin,
>
> On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote:
>> Some boards might not have RTC xtal, so RTC shouldn't really be
>> enabled by default. Enable it in the required board files.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++
>> arch/arm/boot/dts/exynos5420.dtsi | 2 +-
>> 3 files changed, 9 insertions(+), 1 deletion(-)
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Ping Kukjin. Also the other patch for 5250.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] ARM: dts: Re-organize RTC status for 5420
2014-01-03 10:08 ` Sachin Kamat
@ 2014-02-24 0:19 ` Kukjin Kim
0 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2014-02-24 0:19 UTC (permalink / raw)
To: Sachin Kamat; +Cc: Kukjin Kim, linux-samsung-soc, Kukjin Kim
On 01/03/14 19:08, Sachin Kamat wrote:
> On 21 December 2013 02:42, Tomasz Figa<tomasz.figa@gmail.com> wrote:
>> Hi Sachin,
>>
>> On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote:
>>> Some boards might not have RTC xtal, so RTC shouldn't really be
>>> enabled by default. Enable it in the required board files.
>>>
>>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
>>> ---
>>> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++
>>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++
>>> arch/arm/boot/dts/exynos5420.dtsi | 2 +-
>>> 3 files changed, 9 insertions(+), 1 deletion(-)
>>
>> Reviewed-by: Tomasz Figa<t.figa@samsung.com>
>
> Ping Kukjin. Also the other patch for 5250.
>
Applied with 5250 related patch, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-24 0:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-19 10:57 [PATCH 1/1] ARM: dts: Re-organize RTC status for 5420 Sachin Kamat
2013-12-20 21:12 ` Tomasz Figa
2013-12-21 4:05 ` Sachin Kamat
2014-01-03 10:08 ` Sachin Kamat
2014-02-24 0:19 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.