From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
Cc: Jeffy Chen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework
Date: Wed, 08 Aug 2018 08:33:54 +0200 [thread overview]
Message-ID: <1943708.zxIcSzHDJ6@phil> (raw)
In-Reply-To: <20180807085406.3863-2-marc.zyngier-5wv7dgnIgG8@public.gmane.org>
Am Dienstag, 7. August 2018, 10:54:05 CEST schrieb Marc Zyngier:
> pm_runtime_get_if_in_use can fail: either PM has been disabled
> altogether (-EINVAL), or the device hasn't been enabled yet (0).
> Sadly, the Rockchip IOMMU driver tends to conflate the two things
> by considering a non-zero return value as successful.
>
> This has the consequence of hiding other bugs, so let's handle this
> case throughout the driver, with a WARN_ON_ONCE so that we can try
> and work out what happened.
>
> Fixes: 0f181d3cf7d98 ("iommu/rockchip: Add runtime PM support")
> Signed-off-by: Marc Zyngier <marc.zyngier-5wv7dgnIgG8@public.gmane.org>
With Rockchip platforms always selecting PM
[see other longer thread in reply to the patch]
Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework
Date: Wed, 08 Aug 2018 08:33:54 +0200 [thread overview]
Message-ID: <1943708.zxIcSzHDJ6@phil> (raw)
In-Reply-To: <20180807085406.3863-2-marc.zyngier@arm.com>
Am Dienstag, 7. August 2018, 10:54:05 CEST schrieb Marc Zyngier:
> pm_runtime_get_if_in_use can fail: either PM has been disabled
> altogether (-EINVAL), or the device hasn't been enabled yet (0).
> Sadly, the Rockchip IOMMU driver tends to conflate the two things
> by considering a non-zero return value as successful.
>
> This has the consequence of hiding other bugs, so let's handle this
> case throughout the driver, with a WARN_ON_ONCE so that we can try
> and work out what happened.
>
> Fixes: 0f181d3cf7d98 ("iommu/rockchip: Add runtime PM support")
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
With Rockchip platforms always selecting PM
[see other longer thread in reply to the patch]
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Joerg Roedel <joro@8bytes.org>,
Jeffy Chen <jeffy.chen@rock-chips.com>
Subject: Re: [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework
Date: Wed, 08 Aug 2018 08:33:54 +0200 [thread overview]
Message-ID: <1943708.zxIcSzHDJ6@phil> (raw)
In-Reply-To: <20180807085406.3863-2-marc.zyngier@arm.com>
Am Dienstag, 7. August 2018, 10:54:05 CEST schrieb Marc Zyngier:
> pm_runtime_get_if_in_use can fail: either PM has been disabled
> altogether (-EINVAL), or the device hasn't been enabled yet (0).
> Sadly, the Rockchip IOMMU driver tends to conflate the two things
> by considering a non-zero return value as successful.
>
> This has the consequence of hiding other bugs, so let's handle this
> case throughout the driver, with a WARN_ON_ONCE so that we can try
> and work out what happened.
>
> Fixes: 0f181d3cf7d98 ("iommu/rockchip: Add runtime PM support")
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
With Rockchip platforms always selecting PM
[see other longer thread in reply to the patch]
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2018-08-08 6:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 8:54 [PATCH 0/2] iommu/rockchip: Runtime PM fixes Marc Zyngier
2018-08-07 8:54 ` Marc Zyngier
2018-08-07 8:54 ` Marc Zyngier
2018-08-07 8:54 ` [PATCH 1/2] iommu/rockchip: Handle errors returned from PM framework Marc Zyngier
2018-08-07 8:54 ` Marc Zyngier
[not found] ` <20180807085406.3863-2-marc.zyngier-5wv7dgnIgG8@public.gmane.org>
2018-08-07 12:09 ` Heiko Stuebner
2018-08-07 12:09 ` Heiko Stuebner
2018-08-07 12:09 ` Heiko Stuebner
2018-08-07 12:31 ` Marc Zyngier
2018-08-07 12:31 ` Marc Zyngier
2018-08-07 12:31 ` Marc Zyngier
[not found] ` <94b6aab1-e8d3-6929-a2e6-2f06c564bc70-5wv7dgnIgG8@public.gmane.org>
2018-08-07 13:15 ` Heiko Stuebner
2018-08-07 13:15 ` Heiko Stuebner
2018-08-07 13:15 ` Heiko Stuebner
2018-08-07 14:25 ` Marc Zyngier
2018-08-07 14:25 ` Marc Zyngier
[not found] ` <5aa8d184-0c58-3471-a661-8a66a93271c7-5wv7dgnIgG8@public.gmane.org>
2018-08-08 6:30 ` Heiko Stuebner
2018-08-08 6:30 ` Heiko Stuebner
2018-08-08 6:30 ` Heiko Stuebner
2018-08-08 6:33 ` Heiko Stuebner [this message]
2018-08-08 6:33 ` Heiko Stuebner
2018-08-08 6:33 ` Heiko Stuebner
2018-08-07 8:54 ` [PATCH 2/2] iommu/rockchip: Move irq request past pm_runtime_enable Marc Zyngier
2018-08-07 8:54 ` Marc Zyngier
[not found] ` <20180807085406.3863-3-marc.zyngier-5wv7dgnIgG8@public.gmane.org>
2018-08-07 11:45 ` Heiko Stuebner
2018-08-07 11:45 ` Heiko Stuebner
2018-08-07 11:45 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1943708.zxIcSzHDJ6@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=marc.zyngier-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.