All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Racek <tracek@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Alex Elder <elder@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"supporter:XFS FILESYSTEM" <xfs@oss.sgi.com>,
	linux-xfs@vger.kernel.org, Ben Myers <bpm@sgi.com>,
	lczerner@redhat.com
Subject: Re: [PATCH 1/1] xfs: check for possible overflow in xfs_ioc_trim
Date: Tue, 31 Jul 2012 06:32:34 -0400 (EDT)	[thread overview]
Message-ID: <1945505398.1250534.1343730754291.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120730214946.GG2877@dastard>

> > +
> > +	if (range.start > ULLONG_MAX - BBSIZE)
> > +		return -XFS_ERROR(EINVAL);
> > +
> 
> There's no point checking for overflow on the range start - what we
> need to check is whether it is larger than the size of the
> filesystem. We do that after the conversion of range.start to basic
> blocks, so that check needs to be promoted to before this. i.e.
> 
> 	if (range.start >= XFS_FSB_TO_B(mp, mp->m_sb.sb_dblocks))
> 		return -XFS_ERROR(EINVAL);
> 
> >  	start = BTOBB(range.start);
> >  	end = start + BTOBBT(range.len) - 1;
> >  	minlen = BTOBB(max_t(u64, granularity, range.minlen));
> 
> And that will prevent the overflow in BTOBB() just as effectively...

You're right, that's a far better way, I'll change it so.

Thanks!

Tomas

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Tomas Racek <tracek@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Alex Elder <elder@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"supporter:XFS FILESYSTEM" <xfs@oss.sgi.com>,
	linux-xfs@vger.kernel.org, Ben Myers <bpm@sgi.com>,
	lczerner@redhat.com
Subject: Re: [PATCH 1/1] xfs: check for possible overflow in xfs_ioc_trim
Date: Tue, 31 Jul 2012 06:32:34 -0400 (EDT)	[thread overview]
Message-ID: <1945505398.1250534.1343730754291.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20120730214946.GG2877@dastard>

> > +
> > +	if (range.start > ULLONG_MAX - BBSIZE)
> > +		return -XFS_ERROR(EINVAL);
> > +
> 
> There's no point checking for overflow on the range start - what we
> need to check is whether it is larger than the size of the
> filesystem. We do that after the conversion of range.start to basic
> blocks, so that check needs to be promoted to before this. i.e.
> 
> 	if (range.start >= XFS_FSB_TO_B(mp, mp->m_sb.sb_dblocks))
> 		return -XFS_ERROR(EINVAL);
> 
> >  	start = BTOBB(range.start);
> >  	end = start + BTOBBT(range.len) - 1;
> >  	minlen = BTOBB(max_t(u64, granularity, range.minlen));
> 
> And that will prevent the overflow in BTOBB() just as effectively...

You're right, that's a far better way, I'll change it so.

Thanks!

Tomas

  reply	other threads:[~2012-07-31 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30  8:13 [PATCH 1/1] xfs: check for possible overflow in xfs_ioc_trim Tomas Racek
2012-07-30  8:13 ` Tomas Racek
2012-07-30 21:49 ` Dave Chinner
2012-07-30 21:49   ` Dave Chinner
2012-07-31 10:32   ` Tomas Racek [this message]
2012-07-31 10:32     ` Tomas Racek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1945505398.1250534.1343730754291.JavaMail.root@redhat.com \
    --to=tracek@redhat.com \
    --cc=bpm@sgi.com \
    --cc=david@fromorbit.com \
    --cc=elder@kernel.org \
    --cc=lczerner@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.