* [PATCH 1/2] usb: gadget: uvc: constify vb2_ops structure
@ 2018-10-30 15:31 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2018-10-30 15:31 UTC (permalink / raw)
To: Laurent Pinchart
Cc: kernel-janitors, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
The vb2_ops structure can be const as it is only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/usb/gadget/function/uvc_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/uvc_queue.c b/drivers/usb/gadget/function/uvc_queue.c
index 9e33d5206d54..526a10a33094 100644
--- a/drivers/usb/gadget/function/uvc_queue.c
+++ b/drivers/usb/gadget/function/uvc_queue.c
@@ -102,7 +102,7 @@ static void uvc_buffer_queue(struct vb2_buffer *vb)
spin_unlock_irqrestore(&queue->irqlock, flags);
}
-static struct vb2_ops uvc_queue_qops = {
+static const struct vb2_ops uvc_queue_qops = {
.queue_setup = uvc_queue_setup,
.buf_prepare = uvc_buffer_prepare,
.buf_queue = uvc_buffer_queue,
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 1/2] usb: gadget: uvc: constify vb2_ops structure
@ 2018-10-30 15:31 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2018-10-30 15:31 UTC (permalink / raw)
To: Laurent Pinchart
Cc: kernel-janitors, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
The vb2_ops structure can be const as it is only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/usb/gadget/function/uvc_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/uvc_queue.c b/drivers/usb/gadget/function/uvc_queue.c
index 9e33d5206d54..526a10a33094 100644
--- a/drivers/usb/gadget/function/uvc_queue.c
+++ b/drivers/usb/gadget/function/uvc_queue.c
@@ -102,7 +102,7 @@ static void uvc_buffer_queue(struct vb2_buffer *vb)
spin_unlock_irqrestore(&queue->irqlock, flags);
}
-static struct vb2_ops uvc_queue_qops = {
+static const struct vb2_ops uvc_queue_qops = {
.queue_setup = uvc_queue_setup,
.buf_prepare = uvc_buffer_prepare,
.buf_queue = uvc_buffer_queue,
^ permalink raw reply related [flat|nested] 12+ messages in thread* [1/2] usb: gadget: uvc: constify vb2_ops structure
@ 2018-10-30 15:31 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2018-10-30 15:31 UTC (permalink / raw)
To: Laurent Pinchart
Cc: kernel-janitors, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
The vb2_ops structure can be const as it is only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/usb/gadget/function/uvc_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/uvc_queue.c b/drivers/usb/gadget/function/uvc_queue.c
index 9e33d5206d54..526a10a33094 100644
--- a/drivers/usb/gadget/function/uvc_queue.c
+++ b/drivers/usb/gadget/function/uvc_queue.c
@@ -102,7 +102,7 @@ static void uvc_buffer_queue(struct vb2_buffer *vb)
spin_unlock_irqrestore(&queue->irqlock, flags);
}
-static struct vb2_ops uvc_queue_qops = {
+static const struct vb2_ops uvc_queue_qops = {
.queue_setup = uvc_queue_setup,
.buf_prepare = uvc_buffer_prepare,
.buf_queue = uvc_buffer_queue,
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] usb: gadget: uvc: constify vb2_ops structure
@ 2018-10-30 18:54 ` Laurent Pinchart
0 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2018-10-30 18:54 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
Hello Julia,
Thank you for the patch.
On Tuesday, 30 October 2018 17:31:21 EET Julia Lawall wrote:
> The vb2_ops structure can be const as it is only stored in the ops
> field of a vb2_queue structure and this field is const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/usb/gadget/function/uvc_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/uvc_queue.c
> b/drivers/usb/gadget/function/uvc_queue.c index 9e33d5206d54..526a10a33094
> 100644
> --- a/drivers/usb/gadget/function/uvc_queue.c
> +++ b/drivers/usb/gadget/function/uvc_queue.c
> @@ -102,7 +102,7 @@ static void uvc_buffer_queue(struct vb2_buffer *vb)
> spin_unlock_irqrestore(&queue->irqlock, flags);
> }
>
> -static struct vb2_ops uvc_queue_qops = {
> +static const struct vb2_ops uvc_queue_qops = {
> .queue_setup = uvc_queue_setup,
> .buf_prepare = uvc_buffer_prepare,
> .buf_queue = uvc_buffer_queue,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 1/2] usb: gadget: uvc: constify vb2_ops structure
@ 2018-10-30 18:54 ` Laurent Pinchart
0 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2018-10-30 18:54 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
Hello Julia,
Thank you for the patch.
On Tuesday, 30 October 2018 17:31:21 EET Julia Lawall wrote:
> The vb2_ops structure can be const as it is only stored in the ops
> field of a vb2_queue structure and this field is const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/usb/gadget/function/uvc_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/uvc_queue.c
> b/drivers/usb/gadget/function/uvc_queue.c index 9e33d5206d54..526a10a33094
> 100644
> --- a/drivers/usb/gadget/function/uvc_queue.c
> +++ b/drivers/usb/gadget/function/uvc_queue.c
> @@ -102,7 +102,7 @@ static void uvc_buffer_queue(struct vb2_buffer *vb)
> spin_unlock_irqrestore(&queue->irqlock, flags);
> }
>
> -static struct vb2_ops uvc_queue_qops = {
> +static const struct vb2_ops uvc_queue_qops = {
> .queue_setup = uvc_queue_setup,
> .buf_prepare = uvc_buffer_prepare,
> .buf_queue = uvc_buffer_queue,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* [1/2] usb: gadget: uvc: constify vb2_ops structure
@ 2018-10-30 18:54 ` Laurent Pinchart
0 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2018-10-30 18:54 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel
Hello Julia,
Thank you for the patch.
On Tuesday, 30 October 2018 17:31:21 EET Julia Lawall wrote:
> The vb2_ops structure can be const as it is only stored in the ops
> field of a vb2_queue structure and this field is const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/usb/gadget/function/uvc_queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/function/uvc_queue.c
> b/drivers/usb/gadget/function/uvc_queue.c index 9e33d5206d54..526a10a33094
> 100644
> --- a/drivers/usb/gadget/function/uvc_queue.c
> +++ b/drivers/usb/gadget/function/uvc_queue.c
> @@ -102,7 +102,7 @@ static void uvc_buffer_queue(struct vb2_buffer *vb)
> spin_unlock_irqrestore(&queue->irqlock, flags);
> }
>
> -static struct vb2_ops uvc_queue_qops = {
> +static const struct vb2_ops uvc_queue_qops = {
> .queue_setup = uvc_queue_setup,
> .buf_prepare = uvc_buffer_prepare,
> .buf_queue = uvc_buffer_queue,
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] constify vb2_ops structures
@ 2018-10-30 15:31 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2018-10-30 15:31 UTC (permalink / raw)
To: linux-usb; +Cc: kernel-janitors, linux-kernel, linux-media
The vb2_ops structures can be const as they are only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
---
drivers/media/i2c/video-i2c.c | 2 +-
drivers/usb/gadget/function/uvc_queue.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] constify vb2_ops structures
@ 2018-10-30 15:31 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2018-10-30 15:31 UTC (permalink / raw)
To: linux-usb; +Cc: kernel-janitors, linux-kernel, linux-media
The vb2_ops structures can be const as they are only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
---
drivers/media/i2c/video-i2c.c | 2 +-
drivers/usb/gadget/function/uvc_queue.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] media: video-i2c: hwmon: constify vb2_ops structure
2018-10-30 15:31 ` Julia Lawall
@ 2018-10-30 15:31 ` Julia Lawall
-1 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2018-10-30 15:31 UTC (permalink / raw)
To: Matt Ranostay
Cc: kernel-janitors, Mauro Carvalho Chehab, linux-media, linux-kernel
The vb2_ops structure can be const as it is only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/media/i2c/video-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
index 4d49af86c15e..cb89cda6553d 100644
--- a/drivers/media/i2c/video-i2c.c
+++ b/drivers/media/i2c/video-i2c.c
@@ -336,7 +336,7 @@ static void stop_streaming(struct vb2_queue *vq)
video_i2c_del_list(vq, VB2_BUF_STATE_ERROR);
}
-static struct vb2_ops video_i2c_video_qops = {
+static const struct vb2_ops video_i2c_video_qops = {
.queue_setup = queue_setup,
.buf_prepare = buffer_prepare,
.buf_queue = buffer_queue,
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/2] media: video-i2c: hwmon: constify vb2_ops structure
@ 2018-10-30 15:31 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2018-10-30 15:31 UTC (permalink / raw)
To: Matt Ranostay
Cc: kernel-janitors, Mauro Carvalho Chehab, linux-media, linux-kernel
The vb2_ops structure can be const as it is only stored in the ops
field of a vb2_queue structure and this field is const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/media/i2c/video-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
index 4d49af86c15e..cb89cda6553d 100644
--- a/drivers/media/i2c/video-i2c.c
+++ b/drivers/media/i2c/video-i2c.c
@@ -336,7 +336,7 @@ static void stop_streaming(struct vb2_queue *vq)
video_i2c_del_list(vq, VB2_BUF_STATE_ERROR);
}
-static struct vb2_ops video_i2c_video_qops = {
+static const struct vb2_ops video_i2c_video_qops = {
.queue_setup = queue_setup,
.buf_prepare = buffer_prepare,
.buf_queue = buffer_queue,
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] media: video-i2c: hwmon: constify vb2_ops structure
2018-10-30 15:31 ` Julia Lawall
@ 2018-10-30 16:43 ` Matt Ranostay
-1 siblings, 0 replies; 12+ messages in thread
From: Matt Ranostay @ 2018-10-30 16:43 UTC (permalink / raw)
To: Julia.Lawall; +Cc: kernel-janitors, mchehab, linux-media, linux-kernel
On Tue, Oct 30, 2018 at 9:06 AM Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> The vb2_ops structure can be const as it is only stored in the ops
> field of a vb2_queue structure and this field is const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
>
> ---
> drivers/media/i2c/video-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
> index 4d49af86c15e..cb89cda6553d 100644
> --- a/drivers/media/i2c/video-i2c.c
> +++ b/drivers/media/i2c/video-i2c.c
> @@ -336,7 +336,7 @@ static void stop_streaming(struct vb2_queue *vq)
> video_i2c_del_list(vq, VB2_BUF_STATE_ERROR);
> }
>
> -static struct vb2_ops video_i2c_video_qops = {
> +static const struct vb2_ops video_i2c_video_qops = {
> .queue_setup = queue_setup,
> .buf_prepare = buffer_prepare,
> .buf_queue = buffer_queue,
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 2/2] media: video-i2c: hwmon: constify vb2_ops structure
@ 2018-10-30 16:43 ` Matt Ranostay
0 siblings, 0 replies; 12+ messages in thread
From: Matt Ranostay @ 2018-10-30 16:43 UTC (permalink / raw)
To: Julia.Lawall; +Cc: kernel-janitors, mchehab, linux-media, linux-kernel
On Tue, Oct 30, 2018 at 9:06 AM Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> The vb2_ops structure can be const as it is only stored in the ops
> field of a vb2_queue structure and this field is const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Matt Ranostay <matt.ranostay@konsulko.com>
>
> ---
> drivers/media/i2c/video-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
> index 4d49af86c15e..cb89cda6553d 100644
> --- a/drivers/media/i2c/video-i2c.c
> +++ b/drivers/media/i2c/video-i2c.c
> @@ -336,7 +336,7 @@ static void stop_streaming(struct vb2_queue *vq)
> video_i2c_del_list(vq, VB2_BUF_STATE_ERROR);
> }
>
> -static struct vb2_ops video_i2c_video_qops = {
> +static const struct vb2_ops video_i2c_video_qops = {
> .queue_setup = queue_setup,
> .buf_prepare = buffer_prepare,
> .buf_queue = buffer_queue,
>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-10-31 1:38 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-30 15:31 [PATCH 1/2] usb: gadget: uvc: constify vb2_ops structure Julia Lawall
2018-10-30 15:31 ` Julia Lawall
2018-10-30 15:31 ` [1/2] " Julia Lawall
2018-10-30 18:54 ` [PATCH 1/2] " Laurent Pinchart
2018-10-30 18:54 ` Laurent Pinchart
2018-10-30 18:54 ` [1/2] " Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2018-10-30 15:31 [PATCH 0/2] constify vb2_ops structures Julia Lawall
2018-10-30 15:31 ` Julia Lawall
2018-10-30 15:31 ` [PATCH 2/2] media: video-i2c: hwmon: constify vb2_ops structure Julia Lawall
2018-10-30 15:31 ` Julia Lawall
2018-10-30 16:43 ` Matt Ranostay
2018-10-30 16:43 ` Matt Ranostay
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.