From: Tomasz Figa <tomasz.figa@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Kukjin Kim <kgene@kernel.org>,
'Chander Kashyap' <chander.kashyap@linaro.org>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
tglx@linutronix.de, thomas.abraham@linaro.org,
t.figa@samsung.com
Subject: Re: [PATCH v2] irqchip: exynos-combiner: remove hard-coded irq_base value
Date: Thu, 17 Oct 2013 10:53:02 -0700 (PDT) [thread overview]
Message-ID: <1949846.N3fAUHQ1Nx@flatron> (raw)
In-Reply-To: <02c701ceba75$f95b1900$ec114b00$@org>
Hi Kukjin,
On Thursday 26 of September 2013 14:05:09 Kukjin Kim wrote:
> Chander Kashyap wrote:
> > Replace irq_domain_add_simple with "irq_domain_add_linear" in order to
> > use linear irq domain, and to remove hardcoded irq_base_value.
> >
> > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> > ---
> >
> > Changes since v1:
> > - Replaced irq_domain_add_simple with irq_domain_add_linear,
> >
> > as suggested by Tomasz
> >
> > drivers/irqchip/exynos-combiner.c | 15 +++------------
> > 1 file changed, 3 insertions(+), 12 deletions(-)
[snip]
>
> Looks nice to me, applied with Tomasz's review.
I don't see this patch in your tree. Did you apply it in the end?
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] irqchip: exynos-combiner: remove hard-coded irq_base value
Date: Thu, 17 Oct 2013 10:53:02 -0700 (PDT) [thread overview]
Message-ID: <1949846.N3fAUHQ1Nx@flatron> (raw)
In-Reply-To: <02c701ceba75$f95b1900$ec114b00$@org>
Hi Kukjin,
On Thursday 26 of September 2013 14:05:09 Kukjin Kim wrote:
> Chander Kashyap wrote:
> > Replace irq_domain_add_simple with "irq_domain_add_linear" in order to
> > use linear irq domain, and to remove hardcoded irq_base_value.
> >
> > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> > ---
> >
> > Changes since v1:
> > - Replaced irq_domain_add_simple with irq_domain_add_linear,
> >
> > as suggested by Tomasz
> >
> > drivers/irqchip/exynos-combiner.c | 15 +++------------
> > 1 file changed, 3 insertions(+), 12 deletions(-)
[snip]
>
> Looks nice to me, applied with Tomasz's review.
I don't see this patch in your tree. Did you apply it in the end?
Best regards,
Tomasz
next prev parent reply other threads:[~2013-10-17 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 12:03 [PATCH v2] irqchip: exynos-combiner: remove hard-coded irq_base value Chander Kashyap
2013-09-23 12:03 ` Chander Kashyap
2013-09-23 12:10 ` Tomasz Figa
2013-09-23 12:10 ` Tomasz Figa
2013-09-26 5:05 ` Kukjin Kim
2013-09-26 5:05 ` Kukjin Kim
2013-10-17 17:53 ` Tomasz Figa [this message]
2013-10-17 17:53 ` Tomasz Figa
2013-10-20 21:02 ` Kukjin Kim
2013-10-20 21:02 ` Kukjin Kim
2013-11-25 6:37 ` Chander Kashyap
2013-11-25 6:37 ` Chander Kashyap
2013-12-01 22:37 ` Kukjin Kim
2013-12-01 22:37 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1949846.N3fAUHQ1Nx@flatron \
--to=tomasz.figa@gmail.com \
--cc=chander.kashyap@linaro.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
--cc=tglx@linutronix.de \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.