All of lore.kernel.org
 help / color / mirror / Atom feed
From: wuyonggang001@208suo.com
To: Larry.Finger@lwfinger.net, kvalo@kernel.org
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] b43legacy: Remove unneeded variable
Date: Wed, 14 Jun 2023 15:55:29 +0800	[thread overview]
Message-ID: <194e8e87fda5f02664fcfac3717458f2@208suo.com> (raw)
In-Reply-To: <20230614075250.29097-1-zhanglibing@cdjrlc.com>

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded 
variable: "count".

Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>
---
  drivers/net/wireless/broadcom/b43legacy/debugfs.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/debugfs.c 
b/drivers/net/wireless/broadcom/b43legacy/debugfs.c
index 6b0e8d117061..184b0b4bdd94 100644
--- a/drivers/net/wireless/broadcom/b43legacy/debugfs.c
+++ b/drivers/net/wireless/broadcom/b43legacy/debugfs.c
@@ -65,7 +65,6 @@ struct b43legacy_dfs_file * fops_to_dfs_file(struct 
b43legacy_wldev *dev,
  /* wl->irq_lock is locked */
  static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, 
size_t bufsize)
  {
-    ssize_t count = 0;
      u64 tsf;

      b43legacy_tsf_read(dev, &tsf);
@@ -73,7 +72,7 @@ static ssize_t tsf_read_file(struct b43legacy_wldev 
*dev, char *buf, size_t bufs
          (unsigned int)((tsf & 0xFFFFFFFF00000000ULL) >> 32),
          (unsigned int)(tsf & 0xFFFFFFFFULL));

-    return count;
+    return 0;
  }

  /* wl->irq_lock is locked */
@@ -91,7 +90,6 @@ static int tsf_write_file(struct b43legacy_wldev *dev, 
const char *buf, size_t c
  /* wl->irq_lock is locked */
  static ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char 
*buf, size_t bufsize)
  {
-    ssize_t count = 0;
      int i;

      for (i = 0; i < 64; i++) {
@@ -99,7 +97,7 @@ static ssize_t ucode_regs_read_file(struct 
b43legacy_wldev *dev, char *buf, size
              b43legacy_shm_read16(dev, B43legacy_SHM_WIRELESS, i));
      }

-    return count;
+    return 0;
  }

  /* wl->irq_lock is locked */
@@ -125,7 +123,6 @@ static ssize_t shm_read_file(struct b43legacy_wldev 
*dev, char *buf, size_t bufs
  static ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf, 
size_t bufsize)
  {
      struct b43legacy_txstatus_log *log = &dev->dfsentry->txstatlog;
-    ssize_t count = 0;
      unsigned long flags;
      int i, idx;
      struct b43legacy_txstatus *stat;
@@ -166,7 +163,7 @@ static ssize_t txstat_read_file(struct 
b43legacy_wldev *dev, char *buf, size_t b
  out_unlock:
      spin_unlock_irqrestore(&log->lock, flags);

-    return count;
+    return 0;
  }

  /* wl->irq_lock is locked */

WARNING: multiple messages have this Message-ID (diff)
From: wuyonggang001@208suo.com
To: Larry.Finger@lwfinger.net, kvalo@kernel.org
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] b43legacy: Remove unneeded variable
Date: Wed, 14 Jun 2023 15:55:29 +0800	[thread overview]
Message-ID: <194e8e87fda5f02664fcfac3717458f2@208suo.com> (raw)
In-Reply-To: <20230614075250.29097-1-zhanglibing@cdjrlc.com>

Fix the following coccicheck warning:

drivers/net/wireless/broadcom/b43legacy/debugfs.c:68:9-14: Unneeded 
variable: "count".

Signed-off-by: Yonggang Wu <wuyonggang001@208suo.com>
---
  drivers/net/wireless/broadcom/b43legacy/debugfs.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/debugfs.c 
b/drivers/net/wireless/broadcom/b43legacy/debugfs.c
index 6b0e8d117061..184b0b4bdd94 100644
--- a/drivers/net/wireless/broadcom/b43legacy/debugfs.c
+++ b/drivers/net/wireless/broadcom/b43legacy/debugfs.c
@@ -65,7 +65,6 @@ struct b43legacy_dfs_file * fops_to_dfs_file(struct 
b43legacy_wldev *dev,
  /* wl->irq_lock is locked */
  static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, 
size_t bufsize)
  {
-    ssize_t count = 0;
      u64 tsf;

      b43legacy_tsf_read(dev, &tsf);
@@ -73,7 +72,7 @@ static ssize_t tsf_read_file(struct b43legacy_wldev 
*dev, char *buf, size_t bufs
          (unsigned int)((tsf & 0xFFFFFFFF00000000ULL) >> 32),
          (unsigned int)(tsf & 0xFFFFFFFFULL));

-    return count;
+    return 0;
  }

  /* wl->irq_lock is locked */
@@ -91,7 +90,6 @@ static int tsf_write_file(struct b43legacy_wldev *dev, 
const char *buf, size_t c
  /* wl->irq_lock is locked */
  static ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char 
*buf, size_t bufsize)
  {
-    ssize_t count = 0;
      int i;

      for (i = 0; i < 64; i++) {
@@ -99,7 +97,7 @@ static ssize_t ucode_regs_read_file(struct 
b43legacy_wldev *dev, char *buf, size
              b43legacy_shm_read16(dev, B43legacy_SHM_WIRELESS, i));
      }

-    return count;
+    return 0;
  }

  /* wl->irq_lock is locked */
@@ -125,7 +123,6 @@ static ssize_t shm_read_file(struct b43legacy_wldev 
*dev, char *buf, size_t bufs
  static ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf, 
size_t bufsize)
  {
      struct b43legacy_txstatus_log *log = &dev->dfsentry->txstatlog;
-    ssize_t count = 0;
      unsigned long flags;
      int i, idx;
      struct b43legacy_txstatus *stat;
@@ -166,7 +163,7 @@ static ssize_t txstat_read_file(struct 
b43legacy_wldev *dev, char *buf, size_t b
  out_unlock:
      spin_unlock_irqrestore(&log->lock, flags);

-    return count;
+    return 0;
  }

  /* wl->irq_lock is locked */

_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev

       reply	other threads:[~2023-06-14  7:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230614075250.29097-1-zhanglibing@cdjrlc.com>
2023-06-14  7:55 ` wuyonggang001 [this message]
2023-06-14  7:55   ` [PATCH] b43legacy: Remove unneeded variable wuyonggang001
2023-06-14  8:02   ` Johannes Berg
2023-06-14  8:02     ` Johannes Berg
2023-06-14  8:16     ` Johannes Berg
2023-06-14  8:16       ` Johannes Berg
     [not found] <20230612044742.58785-1-zhanglibing@cdjrlc.com>
     [not found] ` <2caa7e16691b9cecab28aec323785a35@208suo.com>
     [not found]   ` <e598894f5a32c00ff905b010bd8e286f@208suo.com>
2023-06-14  5:52     ` wuyonggang001
2023-06-14  7:33       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=194e8e87fda5f02664fcfac3717458f2@208suo.com \
    --to=wuyonggang001@208suo.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.