From: Arnd Bergmann <arnd@arndb.de>
To: broonie@kernel.org
Cc: Nicolin Chen <nicoleotsuka@gmail.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: fsl: fix dependencies for wm8962
Date: Tue, 30 Sep 2014 13:43:41 +0200 [thread overview]
Message-ID: <1950588.ErdGoiHh8p@wuerfel> (raw)
The wm8962 driver uses the input subsystem, but is selected by
SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled,
resulting in this link error:
ERROR: "input_event" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "input_register_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "devm_input_allocate_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
This adds an explicit Kconfig dependency to prevent this configuration
from being used.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 708b4351f08 ("ASoC: fsl: Add Freescale Generic ASoC Sound Card with ASRC support")
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 6164e78b466a..99e9386f7956 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -282,7 +282,7 @@ config SND_SOC_IMX_MC13783
config SND_SOC_FSL_ASOC_CARD
tristate "Generic ASoC Sound Card with ASRC support"
- depends on OF && I2C
+ depends on OF && I2C && INPUT
select SND_SOC_IMX_AUDMUX
select SND_SOC_IMX_PCM_DMA
select SND_SOC_FSL_ESAI
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: fsl: fix dependencies for wm8962
Date: Tue, 30 Sep 2014 13:43:41 +0200 [thread overview]
Message-ID: <1950588.ErdGoiHh8p@wuerfel> (raw)
The wm8962 driver uses the input subsystem, but is selected by
SND_SOC_FSL_ASOC_CARD, which can be built with CONFIG_INPUT disabled,
resulting in this link error:
ERROR: "input_event" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "input_register_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
ERROR: "devm_input_allocate_device" [sound/soc/codecs/snd-soc-wm8962.ko] undefined!
This adds an explicit Kconfig dependency to prevent this configuration
from being used.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 708b4351f08 ("ASoC: fsl: Add Freescale Generic ASoC Sound Card with ASRC support")
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 6164e78b466a..99e9386f7956 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -282,7 +282,7 @@ config SND_SOC_IMX_MC13783
config SND_SOC_FSL_ASOC_CARD
tristate "Generic ASoC Sound Card with ASRC support"
- depends on OF && I2C
+ depends on OF && I2C && INPUT
select SND_SOC_IMX_AUDMUX
select SND_SOC_IMX_PCM_DMA
select SND_SOC_FSL_ESAI
next reply other threads:[~2014-09-30 11:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 11:43 Arnd Bergmann [this message]
2014-09-30 11:43 ` [PATCH] ASoC: fsl: fix dependencies for wm8962 Arnd Bergmann
2014-09-30 16:45 ` Mark Brown
2014-09-30 16:45 ` Mark Brown
2014-09-30 17:38 ` Fabio Estevam
2014-09-30 17:38 ` Fabio Estevam
2014-09-30 19:43 ` Nicolin Chen
2014-09-30 19:43 ` Nicolin Chen
2014-09-30 19:48 ` Fabio Estevam
2014-09-30 19:48 ` Fabio Estevam
2014-09-30 20:37 ` Nicolin Chen
2014-09-30 20:37 ` Nicolin Chen
2014-09-30 17:42 ` Nicolin Chen
2014-09-30 17:42 ` Nicolin Chen
2014-09-30 23:09 ` Mark Brown
2014-09-30 23:09 ` Mark Brown
2014-09-30 23:26 ` Nicolin Chen
2014-09-30 23:26 ` Nicolin Chen
2014-10-01 12:22 ` Mark Brown
2014-10-01 12:22 ` Mark Brown
2014-10-01 17:51 ` Nicolin Chen
2014-10-01 17:51 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1950588.ErdGoiHh8p@wuerfel \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.