All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Chao Zhu <chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] Fix KNI compiling issue on IBM Power
Date: Thu, 04 Dec 2014 12:59:31 +0100	[thread overview]
Message-ID: <1950672.AxEg8fkUWW@xps13> (raw)
In-Reply-To: <1417688048-23076-2-git-send-email-chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

> Because of different cache line size, the alignment of struct
> rte_kni_mbuf in rte_kni_common.h doesn't work on IBM Power. This patch
> changed from 64 to RTE_CACHE_LINE_SIZE micro to do the alignment.
> 
> Signed-off-by: Chao Zhu <chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied

I wonder if we could try to guess the cache line size instead of
configuring it in many places.
Maybe we could use something like sysconf(_SC_LEVEL1_DCACHE_LINESIZE)?

Thanks
-- 
Thomas

  parent reply	other threads:[~2014-12-04 11:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 10:14 [PATCH] Fix KNI compiling on IBM Power Chao Zhu
     [not found] ` <1417688048-23076-1-git-send-email-chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-12-04 10:14   ` [PATCH] Fix KNI compiling issue " Chao Zhu
     [not found]     ` <1417688048-23076-2-git-send-email-chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2014-12-04 11:59       ` Thomas Monjalon [this message]
2014-12-04 13:29         ` Neil Horman
     [not found]           ` <20141204132939.GB16249-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-12-04 13:47             ` Thomas Monjalon
2014-12-04 15:32               ` Neil Horman
     [not found]                 ` <20141204153256.GE16249-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-12-04 15:59                   ` Thomas Monjalon
2014-12-04 20:05                     ` Neil Horman
     [not found]                       ` <20141204200538.GB18930-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-12-05  9:11                         ` Chao Zhu
2014-12-05 13:10                         ` Thomas Monjalon
2014-12-05 14:42                           ` Neil Horman
     [not found]                             ` <20141205144200.GC29245-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2014-12-05 14:52                               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1950672.AxEg8fkUWW@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=chaozhu-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.