Re: [PATCH] Fix KNI compiling issue on IBM Power

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2014-12-05 09:42, Neil Horman:
> On Fri, Dec 05, 2014 at 02:10:27PM +0100, Thomas Monjalon wrote:
> > 2014-12-04 15:05, Neil Horman:
> > > On Thu, Dec 04, 2014 at 04:59:59PM +0100, Thomas Monjalon wrote:
> > > > I'm convinced we need to work on the build system but it's another discussion
> > > > for next weeks. Speaking about that, the AF_PACKET PMD cannot be enabled because
> > > > dependencies are not checked before building it.
> > > > 
> > > I'm fine with that.  If we're going to make the build system contain a depedency
> > > checking mechanism, we'll start dynamically enabling them when support is
> > > detected.  Until then I'm fine with it being an opt in operation, as you know at
> > > build time what you're minimum kernel support levels are.
> > > 
> > > Speaking of enabling however, be careful of a double standard here.  I know that
> > > igb_uio won't build on some kernels either (linvlle posted in the
> > > irc channel about it earlier), because we don't detect the presence of needed
> > > defines.  Yet IGB_UIO is still universally enabled...
> > 
> > I'm really surprised. Please post an email to report the problem.
> > To my knowledge, igb_uio build on every supported Linux distributions
> > (kernel >= 2.6.32).
> > 
> 
> From the IRC session:
> 
> linville   CC [M]
> /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.o
> linville
> /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:
> In function ‘store_max_vfs’:
> linville
> /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:86:2:
> error: implicit declaration of function ‘strict_strtoul’
> [-Werror=implicit-function-declaration]
> linville   if (0 != strict_strtoul(buf, 0, &max_vfs))
> linville   ^

Yes, this issue is being fixed. Jincheng Miao should send a v3:
	http://dpdk.org/ml/archives/dev/2014-December/009182.html

> linville
> /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:
> In function ‘igbuio_dom0_mmap_phys’:
> linville
> /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:290:30:
> error: ‘_PAGE_IOMAP’ undeclared (first use in this function)
> linville   vma->vm_page_prot.pgprot |= _PAGE_IOMAP;
> linville                               ^

Xen is disabled by default. So this issue hasn't been raised yet.
Fixes are welcome.

> linville
> /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:290:30:
> note: each undeclared identifier is reported only once for each function it
> appears in
> linville cc1: all warnings being treated as errors
> linville does igb_uio only work with certain old kernels?
> linville I'm running 3.18-rc7

There are some bugs.
Thanks for reporting (it would more visible in another thread).

-- 
Thomas