All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Stabellini <Stefano.Stabellini@eu.citrix.com>Stefano
Subject: Re: [PATCH] hg ignore libxl lex/yacc detritus
Date: Fri, 23 Jul 2010 16:53:49 +0100	[thread overview]
Message-ID: <19529.47885.676254.574852@mariner.uk.xensource.com> (raw)
In-Reply-To: <C86CE69F.1B4A8%keir.fraser@eu.citrix.com>

Keir Fraser writes ("Re: [Xen-devel] [PATCH] hg ignore libxl lex/yacc detritus"):
> My preference would be to delete the checked-in generated files. Then either
> declare old flex/bison to be simply unsupported, or avoid depending on
> whatever feature it is that is not supported in those old flex/bison
> versions. Checking in the generated output is a cheap hack workaround.

I think what we have now is a good compromise.  If you have working
flex and bison then everything works absolutely fine; if we update the
input files we have to remember to run make before committing but
that's not hard (and I do a build test anyway).

However providing the checked-in files means that people who have
crazy prehistoric versions of flex (1993 in the case of RHEL5 AIUI) or
whatever can still build the system.  If they work in xen-unstable
they may need to knock make on the head, but at least they have a
workaround.  If we didn't provide the generated files checked-in,
the workaround would be much worse.

As an aside, I think there is generally nothing wrong in principle
with checking in generated files.  It's something that should be done
with proper thought and care, but it's often appropriate.  Eg,
automake-using systems should contain configure and configure.in and
Makefile.in, so that people who don't have the right version of
automake can still build from a checkout.

Ian.

      reply	other threads:[~2010-07-23 15:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-16 16:34 [PATCH] hg ignore libxl lex/yacc detritus Dan Magenheimer
2010-07-16 16:50 ` Keir Fraser
2010-07-21 15:26   ` Ian Jackson
2010-07-21 16:42     ` Dan Magenheimer
2010-07-21 16:59       ` Keir Fraser
2010-07-21 17:02         ` Keir Fraser
2010-07-23 15:53           ` Ian Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19529.47885.676254.574852@mariner.uk.xensource.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.