From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH] hg ignore libxl lex/yacc detritus
Date: Fri, 16 Jul 2010 17:50:53 +0100 [thread overview]
Message-ID: <C8664C7D.1ADCC%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <1be65436-b363-4862-a3f4-e55a997014fb@default>
Changeset 21000 checked those files into the tree, so adding them to
.hgignore would be very bad form. I've missed checking in bits of patches
due to that before.
If they are getting modified (i.e., regenerated) as part of your build then
that is a bug. Possibly the rules to generate them should be commented out
in the checked-in Makefile in that case... Whatever, I leave it to Stefano
and Ian to make a decision on that. But the right patch won't touch
.hgignore.
-- Keir
On 16/07/2010 17:34, "Dan Magenheimer" <dan.magenheimer@oracle.com> wrote:
> Please apply (this or some cleaner variation) to
> xen-unstable and xen-4.0-testing so that hg diff
> is clean after a build.
>
> diff -r 57859775f88f .hgignore
> --- a/.hgignore Fri Jul 09 12:44:53 2010 +0100
> +++ b/.hgignore Fri Jul 16 10:24:02 2010 -0600
> @@ -317,3 +317,5 @@
> ^unmodified_drivers/linux-2.6/.*\.ko$
> ^unmodified_drivers/linux-2.6/.*\.mod\.c$
> ^LibVNCServer.*
> +^tools/libxl/libxlu_cfg_l\.h$
> +^tools/libxl/libxlu_cfg_y\.h$
> +^tools/libxl/libxlu_cfg_l\.c$
> +^tools/libxl/libxlu_cfg_y\.c$
next prev parent reply other threads:[~2010-07-16 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 16:34 [PATCH] hg ignore libxl lex/yacc detritus Dan Magenheimer
2010-07-16 16:50 ` Keir Fraser [this message]
2010-07-21 15:26 ` Ian Jackson
2010-07-21 16:42 ` Dan Magenheimer
2010-07-21 16:59 ` Keir Fraser
2010-07-21 17:02 ` Keir Fraser
2010-07-23 15:53 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8664C7D.1ADCC%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=dan.magenheimer@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.