From: Heiko Stuebner <heiko@sntech.de>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: devicetree@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org,
Vicente Bergas <vicencb@gmail.com>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
Christoph Muellner <christoph.muellner@theobroma-systems.com>,
Randy Li <ayaka@soulik.info>, Tony Xie <tony.xie@rock-chips.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Update DWC3 modules on RK3399 SoCs
Date: Thu, 27 Jun 2019 14:42:46 +0200 [thread overview]
Message-ID: <1960228.jn0vabPeDx@phil> (raw)
In-Reply-To: <20190613162745.12195-1-enric.balletbo@collabora.com>
Am Donnerstag, 13. Juni 2019, 18:27:45 CEST schrieb Enric Balletbo i Serra:
> As per binding documentation [1], the DWC3 core should have the "ref",
> "bus_early" and "suspend" clocks. As explained in the binding, those
> clocks are required for new platforms but not for existing platforms
> before commit fe8abf332b8f ("usb: dwc3: support clocks and resets for
> DWC3 core").
>
> However, as those clocks are really treated as required, this ends with
> having some annoying messages when the "rockchip,rk3399-dwc3" is used:
>
> [ 1.724107] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2
> [ 1.731893] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2
> [ 2.495937] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2
> [ 2.647239] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2
>
> In order to remove those annoying messages, update the DWC3 hardware
> module node and add all the required clocks. With this change, both, the
> glue node and the DWC3 core node, have the clocks defined, but that's
> not really a problem and there isn't a side effect on do this. So, we
> can get rid of the annoying get clk error messages.
>
> [1] Documentation/devicetree/bindings/usb/dwc3.txt
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
applied for 5.3
Thanks
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Tony Xie <tony.xie@rock-chips.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Randy Li <ayaka@soulik.info>,
linux-kernel@vger.kernel.org, Vicente Bergas <vicencb@gmail.com>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Collabora Kernel ML <kernel@collabora.com>,
linux-arm-kernel@lists.infradead.org,
Christoph Muellner <christoph.muellner@theobroma-systems.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Update DWC3 modules on RK3399 SoCs
Date: Thu, 27 Jun 2019 14:42:46 +0200 [thread overview]
Message-ID: <1960228.jn0vabPeDx@phil> (raw)
In-Reply-To: <20190613162745.12195-1-enric.balletbo@collabora.com>
Am Donnerstag, 13. Juni 2019, 18:27:45 CEST schrieb Enric Balletbo i Serra:
> As per binding documentation [1], the DWC3 core should have the "ref",
> "bus_early" and "suspend" clocks. As explained in the binding, those
> clocks are required for new platforms but not for existing platforms
> before commit fe8abf332b8f ("usb: dwc3: support clocks and resets for
> DWC3 core").
>
> However, as those clocks are really treated as required, this ends with
> having some annoying messages when the "rockchip,rk3399-dwc3" is used:
>
> [ 1.724107] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2
> [ 1.731893] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2
> [ 2.495937] dwc3 fe800000.dwc3: Failed to get clk 'ref': -2
> [ 2.647239] dwc3 fe900000.dwc3: Failed to get clk 'ref': -2
>
> In order to remove those annoying messages, update the DWC3 hardware
> module node and add all the required clocks. With this change, both, the
> glue node and the DWC3 core node, have the clocks defined, but that's
> not really a problem and there isn't a side effect on do this. So, we
> can get rid of the annoying get clk error messages.
>
> [1] Documentation/devicetree/bindings/usb/dwc3.txt
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
applied for 5.3
Thanks
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-27 12:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 16:27 [PATCH] arm64: dts: rockchip: Update DWC3 modules on RK3399 SoCs Enric Balletbo i Serra
2019-06-13 16:27 ` Enric Balletbo i Serra
2019-06-13 16:56 ` Robin Murphy
2019-06-13 16:56 ` Robin Murphy
2019-06-13 16:56 ` Robin Murphy
2019-06-13 17:20 ` Enric Balletbo i Serra
2019-06-13 17:20 ` Enric Balletbo i Serra
2019-06-13 17:44 ` Robin Murphy
2019-06-13 17:44 ` Robin Murphy
2019-06-16 14:25 ` Heiko Stübner
2019-06-16 14:25 ` Heiko Stübner
2019-06-27 12:42 ` Heiko Stuebner [this message]
2019-06-27 12:42 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1960228.jn0vabPeDx@phil \
--to=heiko@sntech.de \
--cc=ayaka@soulik.info \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=felipe.balbi@linux.intel.com \
--cc=kernel@collabora.com \
--cc=klaus.goger@theobroma-systems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=vicencb@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.