All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: boris.brezillon@free-electrons.com, dwmw2@infradead.org,
	computersforpeace@gmail.com, marek.vasut@gmail.com,
	cyrille.pitchen@wedev4u.fr, outreachy-kernel@googlegroups.com,
	ezequiel@vanguardiasur.com.ar
Subject: Re: [PATCH NAND 0/5] Replace printk statements with pr_*macros
Date: Fri, 16 Feb 2018 18:19:40 +0100	[thread overview]
Message-ID: <1963507.Bpu1nn9g4S@blindfold> (raw)
In-Reply-To: <cover.1518797480.git.shreeya.patel23498@gmail.com>

Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:
> This patchset removes all the log levels i.e. KERN_WARN,
> KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk
> statements and replaces the printk statements with appropriate
> pr_*macros.
> According to the kernel coding style, pr_*macro is the preferred
> way to print the message.

Beside of that, how does it improve the code?
Don't get me wrong, pr_* is the way to go for new code, but I don't think it 
is worth "fixing" in existing code and make working with git blame more 
painful.

Thanks,
//richard


  parent reply	other threads:[~2018-02-16 17:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 16:50 [PATCH NAND 0/5] Replace printk statements with pr_*macros Shreeya Patel
2018-02-16 16:55 ` [PATCH NAND 1/5] mtd/nand: Replace printk with pr_warn Shreeya Patel
2018-02-16 17:08   ` [Outreachy kernel] " Julia Lawall
2018-02-16 17:52     ` Shreeya Patel
2018-02-16 16:57 ` [PATCH NAND 2/5] mtd/nand: Replace printk with pr_notice Shreeya Patel
2018-02-16 17:00 ` [PATCH NAND 3/5] mtd/nand: Replace printk with pr_err Shreeya Patel
2018-02-16 17:03 ` [PATCH NAND 4/5] mtd/nand: Replace printk with pr_info Shreeya Patel
2018-02-16 17:08 ` [PATCH NAND 5/5] mtd/nand: Replace printk with pr_debug Shreeya Patel
2018-02-16 17:19 ` Richard Weinberger [this message]
2018-02-16 17:24   ` [PATCH NAND 0/5] Replace printk statements with pr_*macros Ezequiel Garcia
2018-02-16 17:25     ` Ezequiel Garcia
2018-02-16 17:58     ` Richard Weinberger
2018-02-16 18:15       ` Boris Brezillon
2018-02-16 18:48     ` [Outreachy kernel] " Greg KH
2018-02-16 18:54       ` Julia Lawall
2018-02-16 18:00   ` Boris Brezillon
2018-02-16 17:19 ` Ezequiel Garcia
2018-02-16 17:23   ` [Outreachy kernel] " Julia Lawall
2018-02-16 17:26     ` Ezequiel Garcia
2018-02-16 17:48       ` Boris Brezillon
2018-02-16 17:59         ` Shreeya Patel
     [not found]         ` <1518976870.2784.4.camel@gmail.com>
     [not found]           ` <20180218191347.76f4a287@bbrezillon>
     [not found]             ` <1518978365.2969.6.camel@gmail.com>
2018-02-18 20:09               ` Boris Brezillon
2018-02-18 20:20                 ` Shreeya Patel
2018-02-18 20:30                 ` Shreeya Patel
2018-02-16 17:35   ` Shreeya Patel
2018-02-16 17:45   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1963507.Bpu1nn9g4S@blindfold \
    --to=richard@nod.at \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=marek.vasut@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shreeya.patel23498@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.