Re: [Outreachy kernel] Re: [PATCH NAND 0/5] Replace printk statements with pr_*macros

[Greg KH <greg@kroah.com>]

On Fri, Feb 16, 2018 at 02:24:46PM -0300, Ezequiel Garcia wrote:
> Hey Richard,
> 
> On 16 February 2018 at 14:19, Richard Weinberger <richard@nod.at> wrote:
> > Am Freitag, 16. Februar 2018, 17:50:09 CET schrieb Shreeya Patel:
> >> This patchset removes all the log levels i.e. KERN_WARN,
> >> KERN_NOTICE, KERN_ERR, KERN_INFO, KERN_DEBUG used in the printk
> >> statements and replaces the printk statements with appropriate
> >> pr_*macros.
> >> According to the kernel coding style, pr_*macro is the preferred
> >> way to print the message.
> >
> > Beside of that, how does it improve the code?
> > Don't get me wrong, pr_* is the way to go for new code, but I don't think it
> > is worth "fixing" in existing code and make working with git blame more
> > painful.
> >
> 
> Shreeya's intention is to work on [1], migrating drivers to exec_op.
> As a first task, before being accepted, she is required to submit
> cleanup patches (or small tasks).

"cleanup patches" should always start in the drivers/staging/ tree, to
avoid bothering other subsytem maintainers.  Please start there before
moving on to the "tasks" as mentioned on the site that are picked by the
mentors.

Don't skip the cleanup patches for no good reason please.

thanks,

greg k-h