From: Sven Eckelmann <sven@narfation.org>
To: David Lee <david.lee@trailofbits.com>, Kyle Zeng <kylebot@openai.com>
Cc: Dominik 'Disconnect3d' Czarnota
<dominik.czarnota@trailofbits.com>,
b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] batman-adv: reject unrepresentable multicast TVLV offsets
Date: Sat, 01 Aug 2026 11:55:39 +0200 [thread overview]
Message-ID: <1966817.atdPhlSkOF@sven-desktop> (raw)
In-Reply-To: <178551276852.62695.13954065440231922020.b4-review@b4>
[-- Attachment #1: Type: text/plain, Size: 947 bytes --]
On Friday, 31 July 2026 17:46:08 CEST Sven Eckelmann wrote:
> On Fri, 31 Jul 2026 13:52:22 +0000, David Lee <david.lee@trailofbits.com> wrote:
> > batman-adv: reject unrepresentable multicast TVLV offsets
>
> Acked-by: Sven Eckelmann <sven@narfation.org>
I am hereby withdrawing this.
NACKed-by: Sven Eckelmann <sven@narfation.org>
This needs a different implementation and a clean patch submission. Summary:
1. weird text + newlines in the tags section which shouldn't be there
2. author didn't sign off the patch
3. weird unrelated Signed-off-by without any understandable connection to
patch
4. the checks should be in the API and not added in random places in callers
of the API (which makes it hard to understand why the check is there). The
users of the API should only handle the return values of the API functions.
See commit d45cf1e7d718 ("ipv6: reject malicious packets in
ipv6_gso_segment()")
Regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-08-01 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 13:52 [PATCH] batman-adv: reject unrepresentable multicast TVLV offsets David Lee
2026-07-31 15:46 ` Sven Eckelmann
2026-08-01 9:55 ` Sven Eckelmann [this message]
2026-07-31 15:46 ` Sven Eckelmann
2026-07-31 19:05 ` Sven Eckelmann
2026-08-01 9:54 ` [PATCH] batman-adv: reject unrepresentable multicast TVLV offsets (+ b4 check signed-off-problems) Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1966817.atdPhlSkOF@sven-desktop \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=david.lee@trailofbits.com \
--cc=dominik.czarnota@trailofbits.com \
--cc=kylebot@openai.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.