From: David Ahern <dsahern@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>,
Denis Kirjanov <kirjanov@gmail.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
Denis Kirjanov <dkirjanov@suse.de>
Subject: Re: [PATCH iproute2] ifstat: handle strdup return value
Date: Thu, 14 Mar 2024 20:34:43 -0600 [thread overview]
Message-ID: <19699d5f-29d7-4e14-b954-d612c5035b4a@kernel.org> (raw)
In-Reply-To: <20240315022329.GA1295449@maili.marvell.com>
On 3/14/24 8:23 PM, Ratheesh Kannoth wrote:
>> diff --git a/misc/ifstat.c b/misc/ifstat.c
>> index 685e66c9..f94b11bc 100644
>> --- a/misc/ifstat.c
>> +++ b/misc/ifstat.c
>> @@ -140,6 +140,11 @@ static int get_nlmsg_extended(struct nlmsghdr *m, void *arg)
>>
>> n->ifindex = ifsm->ifindex;
>> n->name = strdup(ll_index_to_name(ifsm->ifindex));
>> + if (!n->name) {
>> + free(n);
>> + errno = ENOMEM;
> strdup() will set the errno right ? why do you need to set it explicitly ?
agreed.
pw-bot: cr
next prev parent reply other threads:[~2024-03-15 2:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 12:20 [PATCH iproute2] ifstat: handle strdup return value Denis Kirjanov
2024-03-15 2:23 ` Ratheesh Kannoth
2024-03-15 2:34 ` David Ahern [this message]
2024-03-15 4:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19699d5f-29d7-4e14-b954-d612c5035b4a@kernel.org \
--to=dsahern@kernel.org \
--cc=dkirjanov@suse.de \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rkannoth@marvell.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.