Re: [PATCH iproute2] ifstat: handle strdup return value

[Ratheesh Kannoth <rkannoth@marvell.com>]

On 2024-03-14 at 17:50:40, Denis Kirjanov (kirjanov@gmail.com) wrote:
> get_nlmsg_extended missing the check as it's done
> in get_nlmsg
>
> Signed-off-by: Denis Kirjanov <dkirjanov@suse.de>
> ---
>  misc/ifstat.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/misc/ifstat.c b/misc/ifstat.c
> index 685e66c9..f94b11bc 100644
> --- a/misc/ifstat.c
> +++ b/misc/ifstat.c
> @@ -140,6 +140,11 @@ static int get_nlmsg_extended(struct nlmsghdr *m, void *arg)
>
>  	n->ifindex = ifsm->ifindex;
>  	n->name = strdup(ll_index_to_name(ifsm->ifindex));
> +	if (!n->name) {
> +		free(n);
> +		errno = ENOMEM;
strdup() will set the errno right ? why do you need to set it explicitly ?
> +		return -1;
> +	}
>
>  	if (sub_type == NO_SUB_TYPE) {
>  		memcpy(&n->val, RTA_DATA(tb[filter_type]), sizeof(n->val));
> --
> 2.30.2
>