All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hebbar <gururajakr@sanyo.co.in>
To: u-boot@lists.denx.de
Subject: [U-Boot] ARM Versatile port - possibly inefficient code?
Date: Tue, 30 Sep 2008 03:10:30 -0700 (PDT)	[thread overview]
Message-ID: <19739341.post@talk.nabble.com> (raw)
In-Reply-To: <40a670230809292340u249e1c87tccd6e32f6f711550@mail.gmail.com>


Hi,



>>Regardless of CFG_MAX_FLASH_BANKS value, the only first bank is
>>configured. Was it done deliberately or it's logical flaw? I think
>>is code could cloned on a multiple of other platforms.

ARM Versatile has only one flash bank.
What if a user has configured an incorrect number for flash banks. 
The driver should take care of this properly. Since CFG_MAX_FLASH_BANKS 
is in a different place & the flash.c is a different file, care is taken to
see 
that an incorrect bank is not considered for initialization

also,

>>panic ("configured too many flash banks!\n"); 
this error message clearly explains the mistake the user did.

Regards
Gururaja

-- 
View this message in context: http://www.nabble.com/-U-Boot--ARM-Versatile-port---possibly-inefficient-code--tp19736928p19739341.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

  reply	other threads:[~2008-09-30 10:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30  6:40 [U-Boot] ARM Versatile port - possibly inefficient code? Roman Mashak
2008-09-30 10:10 ` Hebbar [this message]
2008-09-30 11:19   ` Roman Mashak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19739341.post@talk.nabble.com \
    --to=gururajakr@sanyo.co.in \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.