All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, wsa@the-dreams.de,
	linus.walleij@linaro.org, linux-sh@vger.kernel.org,
	horms@verge.net.au
Subject: Re: [PATCH] pinctrl: sh-pfc: Initial r7s72100 support
Date: Wed, 27 Nov 2013 11:14:35 +0000	[thread overview]
Message-ID: <1976247.WEVz5t99cX@avalon> (raw)
In-Reply-To: <20131127074122.18314.48522.sendpatchset@w520>

Hi Magnus,

On Wednesday 27 November 2013 16:41:22 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add r7s72100 PINCTRL support via sh-pfc. At this point this code
> provides enough support to allow use together with the gpio-rz
> driver. Incremental per-device patches will in the future be
> submitted on top of this base patch to allow PINCTRL enablement
> for each individual device.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  drivers/pinctrl/sh-pfc/Kconfig        |    5
>  drivers/pinctrl/sh-pfc/Makefile       |    1
>  drivers/pinctrl/sh-pfc/core.c         |    9 +
>  drivers/pinctrl/sh-pfc/core.h         |    1
>  drivers/pinctrl/sh-pfc/pfc-r7s72100.c |  166 ++++++++++++++++++++++++++++++

One more comment, you should update the DT bindings documentation with the new 
compatible string.

>  5 files changed, 182 insertions(+)

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, wsa@the-dreams.de,
	linus.walleij@linaro.org, linux-sh@vger.kernel.org,
	horms@verge.net.au
Subject: Re: [PATCH] pinctrl: sh-pfc: Initial r7s72100 support
Date: Wed, 27 Nov 2013 12:14:35 +0100	[thread overview]
Message-ID: <1976247.WEVz5t99cX@avalon> (raw)
In-Reply-To: <20131127074122.18314.48522.sendpatchset@w520>

Hi Magnus,

On Wednesday 27 November 2013 16:41:22 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add r7s72100 PINCTRL support via sh-pfc. At this point this code
> provides enough support to allow use together with the gpio-rz
> driver. Incremental per-device patches will in the future be
> submitted on top of this base patch to allow PINCTRL enablement
> for each individual device.
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  drivers/pinctrl/sh-pfc/Kconfig        |    5
>  drivers/pinctrl/sh-pfc/Makefile       |    1
>  drivers/pinctrl/sh-pfc/core.c         |    9 +
>  drivers/pinctrl/sh-pfc/core.h         |    1
>  drivers/pinctrl/sh-pfc/pfc-r7s72100.c |  166 ++++++++++++++++++++++++++++++

One more comment, you should update the DT bindings documentation with the new 
compatible string.

>  5 files changed, 182 insertions(+)

-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2013-11-27 11:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  7:41 [PATCH] pinctrl: sh-pfc: Initial r7s72100 support Magnus Damm
2013-11-27  7:41 ` Magnus Damm
2013-11-27 10:54 ` Laurent Pinchart
2013-11-27 10:54   ` Laurent Pinchart
2013-12-17 23:31   ` Magnus Damm
2013-12-17 23:31     ` Magnus Damm
2013-11-27 11:14 ` Laurent Pinchart [this message]
2013-11-27 11:14   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1976247.WEVz5t99cX@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=horms@verge.net.au \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.