* [PATCH] video: fbdev: remove redundant self assignment of 'height'
@ 2017-11-23 10:55 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-11-23 10:55 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment of height to itself is redundant and can be removed.
Detected with Coccinelle.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/vga16fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 5f0690c8fc93..2c6a576ed84c 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -1055,7 +1055,6 @@ static void vga16fb_copyarea(struct fb_info *info, const struct fb_copyarea *are
case FB_TYPE_VGA_PLANES:
if (info->fix.type_aux = FB_AUX_VGA_PLANES_VGA4) {
width = width/8;
- height = height;
line_ofs = info->fix.line_length - width;
setmode(1);
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: remove redundant self assignment of 'height'
@ 2017-11-23 10:55 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-11-23 10:55 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment of height to itself is redundant and can be removed.
Detected with Coccinelle.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/vga16fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 5f0690c8fc93..2c6a576ed84c 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -1055,7 +1055,6 @@ static void vga16fb_copyarea(struct fb_info *info, const struct fb_copyarea *are
case FB_TYPE_VGA_PLANES:
if (info->fix.type_aux == FB_AUX_VGA_PLANES_VGA4) {
width = width/8;
- height = height;
line_ofs = info->fix.line_length - width;
setmode(1);
--
2.14.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] video: fbdev: remove redundant self assignment of 'height'
@ 2017-11-23 10:55 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2017-11-23 10:55 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment of height to itself is redundant and can be removed.
Detected with Coccinelle.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/video/fbdev/vga16fb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 5f0690c8fc93..2c6a576ed84c 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -1055,7 +1055,6 @@ static void vga16fb_copyarea(struct fb_info *info, const struct fb_copyarea *are
case FB_TYPE_VGA_PLANES:
if (info->fix.type_aux == FB_AUX_VGA_PLANES_VGA4) {
width = width/8;
- height = height;
line_ofs = info->fix.line_length - width;
setmode(1);
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: remove redundant self assignment of 'height'
2017-11-23 10:55 ` Colin King
(?)
@ 2017-12-29 17:36 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-12-29 17:36 UTC (permalink / raw)
To: Colin King; +Cc: linux-fbdev, kernel-janitors, linux-kernel, dri-devel
On Thursday, November 23, 2017 10:55:53 AM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment of height to itself is redundant and can be removed.
> Detected with Coccinelle.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: remove redundant self assignment of 'height'
@ 2017-12-29 17:36 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-12-29 17:36 UTC (permalink / raw)
To: Colin King; +Cc: linux-fbdev, kernel-janitors, linux-kernel, dri-devel
On Thursday, November 23, 2017 10:55:53 AM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment of height to itself is redundant and can be removed.
> Detected with Coccinelle.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] video: fbdev: remove redundant self assignment of 'height'
@ 2017-12-29 17:36 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2017-12-29 17:36 UTC (permalink / raw)
To: Colin King; +Cc: dri-devel, linux-fbdev, kernel-janitors, linux-kernel
On Thursday, November 23, 2017 10:55:53 AM Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment of height to itself is redundant and can be removed.
> Detected with Coccinelle.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-29 17:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171123105559epcas5p2098447b1667bcb96fa6162fdd939dce0@epcas5p2.samsung.com>
2017-11-23 10:55 ` [PATCH] video: fbdev: remove redundant self assignment of 'height' Colin King
2017-11-23 10:55 ` Colin King
2017-11-23 10:55 ` Colin King
2017-12-29 17:36 ` Bartlomiej Zolnierkiewicz
2017-12-29 17:36 ` Bartlomiej Zolnierkiewicz
2017-12-29 17:36 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.