[PATCH v2 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi

[PATCH v2 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi

[Sachin Kamat]

Fix the name as per DT node naming convention.
- rename the node to syscon which is a more generic name.
- append the register value to the node name.

Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
Changes since v1:
 * Renamed the node to syscon as suggested by Tomasz Figa.
---
 arch/arm/boot/dts/exynos4.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index e2629464376f..ce24edba7f6d 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -99,7 +99,7 @@
 		reg = <0x10440000 0x1000>;
 	};
 
-	sys_reg: sysreg {
+	sys_reg: syscon@10010000 {
 		compatible = "samsung,exynos4-sysreg", "syscon";
 		reg = <0x10010000 0x400>;
 	};
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] ARM: dts: Update Samsung sysreg binding document

[Sachin Kamat]

Added a binding example for reference and updated the
node name.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 .../devicetree/bindings/arm/samsung/sysreg.txt     |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
index 5039c0a12f55..f165567a9df0 100644
--- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
@@ -1,7 +1,13 @@
 SAMSUNG S5P/Exynos SoC series System Registers (SYSREG)
 
 Properties:
- - name : should be 'sysreg';
+ - name : should be 'syscon';
  - compatible : should contain "samsung,<chip name>-sysreg", "syscon";
    For Exynos4 SoC series it should be "samsung,exynos4-sysreg", "syscon";
  - reg : offset and length of the register set.
+
+Example:
+	syscon@10010000 {
+		compatible = "samsung,exynos4-sysreg", "syscon";
+		reg = <0x10010000 0x400>;
+	};
-- 
1.7.9.5

Re: [PATCH v2 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi

[Tomasz Figa]

On Thursday 31 of October 2013 10:16:53 Sachin Kamat wrote:
> Fix the name as per DT node naming convention.
> - rename the node to syscon which is a more generic name.
> - append the register value to the node name.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> Changes since v1:
>  * Renamed the node to syscon as suggested by Tomasz Figa.
> ---
>  arch/arm/boot/dts/exynos4.dtsi |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

Re: [PATCH v2 2/2] ARM: dts: Update Samsung sysreg binding document

[Tomasz Figa]

Hi Sachin,

On Thursday 31 of October 2013 10:16:54 Sachin Kamat wrote:
> Added a binding example for reference and updated the
> node name.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  .../devicetree/bindings/arm/samsung/sysreg.txt     |    8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> index 5039c0a12f55..f165567a9df0 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/sysreg.txt
> @@ -1,7 +1,13 @@
>  SAMSUNG S5P/Exynos SoC series System Registers (SYSREG)
>  
>  Properties:
> - - name : should be 'sysreg';
> + - name : should be 'syscon';

I didn't notice this before, but a device binding should not rather
require any specific name of its top level node, so I'd simply remove this
line.

Otherwise the patch looks fine.

Best regards,
Tomasz