[PATCH] [40network] Fix ifup.sh to always execute initqueue/online hook after bringing up an interface

[PATCH] [40network] Fix ifup.sh to always execute initqueue/online hook after bringing up an interface

[Dennis Schridde]

---
 modules.d/40network/ifup.sh | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/modules.d/40network/ifup.sh b/modules.d/40network/ifup.sh
index 526251f..13be22a 100755
--- a/modules.d/40network/ifup.sh
+++ b/modules.d/40network/ifup.sh
@@ -307,19 +307,13 @@ for p in $(getargs ip=); do
             do_static ;;
     esac
 
-    case $autoconf in
-        dhcp|on|any|dhcp6)
-            ;;
-        *)
-            if [ $? -eq 0 ]; then
-                setup_net $netif
-                source_hook initqueue/online $netif
-                if [ -z "$manualup" ]; then
-                    /sbin/netroot $netif
-                fi
-            fi
-            ;;
-    esac
+    if [ $? -eq 0 ]; then
+        setup_net $netif
+        source_hook initqueue/online $netif
+        if [ -z "$manualup" ]; then
+            /sbin/netroot $netif
+        fi
+    fi
 
     break
 done
-- 
1.8.1.5

Re: [PATCH] [40network] Fix ifup.sh to always execute initqueue/online hook after bringing up an interface

[Harald Hoyer]

Am 11.04.2013 17:41, schrieb Dennis Schridde:
> ---
>  modules.d/40network/ifup.sh | 20 +++++++-------------
>  1 file changed, 7 insertions(+), 13 deletions(-)
> 
> diff --git a/modules.d/40network/ifup.sh b/modules.d/40network/ifup.sh
> index 526251f..13be22a 100755
> --- a/modules.d/40network/ifup.sh
> +++ b/modules.d/40network/ifup.sh
> @@ -307,19 +307,13 @@ for p in $(getargs ip=); do
>              do_static ;;
>      esac
>  
> -    case $autoconf in
> -        dhcp|on|any|dhcp6)
> -            ;;
> -        *)
> -            if [ $? -eq 0 ]; then
> -                setup_net $netif
> -                source_hook initqueue/online $netif
> -                if [ -z "$manualup" ]; then
> -                    /sbin/netroot $netif
> -                fi
> -            fi
> -            ;;
> -    esac
> +    if [ $? -eq 0 ]; then
> +        setup_net $netif
> +        source_hook initqueue/online $netif
> +        if [ -z "$manualup" ]; then
> +            /sbin/netroot $netif
> +        fi
> +    fi
>  
>      break
>  done
> 

IIRC, that is done, as soon as the dhcp client gets an IP

Re: [PATCH] [40network] Fix ifup.sh to always execute initqueue/online hook after bringing up an interface

[Dennis Schridde]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

Am Donnerstag, 11. April 2013, 17:44:08 schrieb Harald Hoyer:
> IIRC, that is done, as soon as the dhcp client gets an IP

These patches are already a few months old, so dracut's behaviour may very 
well have changed in the meantime. Where does what you describe happen?

--Dennis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] [40network] Fix ifup.sh to always execute initqueue/online hook after bringing up an interface

[Will Woods]

On Thu, 2013-04-11 at 18:13 +0200, Dennis Schridde wrote:
> Am Donnerstag, 11. April 2013, 17:44:08 schrieb Harald Hoyer:
> > IIRC, that is done, as soon as the dhcp client gets an IP

Technically it doesn't happen *immediately* - it adds a job to the
initqueue, and that job will run the initqueue/online hook.

> These patches are already a few months old, so dracut's behaviour may very 
> well have changed in the meantime. Where does what you describe happen?

See 40network/dhclient-script.sh - when $reason is BOUND (i.e. initial
binding to a new address, as per dhclient-script(8)), it adds a job
named "setup_net_$netif.sh" to the initqueue.

Hope that helps,

-w

Re: [PATCH] [40network] Fix ifup.sh to always execute initqueue/online hook after bringing up an interface

[Dennis Schridde]

[-- Attachment #1: Type: text/plain, Size: 942 bytes --]

Hello!

Am Dienstag, 30. April 2013, 15:25:15 schrieb Will Woods:
> On Thu, 2013-04-11 at 18:13 +0200, Dennis Schridde wrote:
> > Am Donnerstag, 11. April 2013, 17:44:08 schrieb Harald Hoyer:
> > > IIRC, that is done, as soon as the dhcp client gets an IP
> 
> Technically it doesn't happen *immediately* - it adds a job to the
> initqueue, and that job will run the initqueue/online hook.
> 
> > These patches are already a few months old, so dracut's behaviour may very
> > well have changed in the meantime. Where does what you describe happen?
> 
> See 40network/dhclient-script.sh - when $reason is BOUND (i.e. initial
> binding to a new address, as per dhclient-script(8)), it adds a job
> named "setup_net_$netif.sh" to the initqueue.

Thanks for that information!

I removed the patch and discovered some bugs and misconceptions about the 
inner workings of dracut in my own code. It works now without the patch.

Best regards,
Dennis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] [40network] Fix ifup.sh to always execute initqueue/online hook after bringing up an interface

[Dennis Schridde]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

Hello!

This fix is required for net_add_parse_vars in my "[PATCH 1/2] [40network] Add 
variable parsing framework for network related variables" to work properly. 

The online hook was previously not executed for dhcp enabled interfaces, which 
resulted in my code not being executed.

--Dennis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]