From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, thierry.herbelot@6wind.com, stable@dpdk.org,
Robin Jarry <rjarry@redhat.com>
Subject: Re: [PATCH] usertools/pmdinfo: fix search for PMD info string
Date: Tue, 17 Mar 2026 14:57:12 +0100 [thread overview]
Message-ID: <1996966.6tgchFWduM@thomas> (raw)
In-Reply-To: <DGHZMMMMIQHE.2D7VL676OEQST@redhat.com>
18/02/2026 10:41, Robin Jarry:
> Bruce Richardson, Feb 17, 2026 at 13:48:
> > The PMD_INFO_STRING constant string is not guaranteed to appear in the
> > output binary immediately after an unprintable character. Because of
> > this, in some cases the information for a driver could be missed by the
> > PMD info script as it only checks for the prefix at the start of strings
> > that it finds. Change the script to use "s.find()" rather than
> > "s.startswith()" to fix this issue.
> >
> > Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Nice find. Thanks Bruce.
>
> Acked-by: Robin Jarry <rjarry@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2026-03-17 13:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 16:21 [PATCH] drivers/net: reorder Intel drivers list in meson script Thierry Herbelot
2026-01-23 16:27 ` [V2] " Thierry Herbelot
2026-01-23 16:50 ` Bruce Richardson
2026-01-23 16:57 ` Thierry Herbelot
2026-02-16 10:48 ` Bruce Richardson
2026-02-16 11:32 ` Bruce Richardson
2026-02-16 17:39 ` Thomas Monjalon
2026-02-17 12:48 ` [PATCH] usertools/pmdinfo: fix search for PMD info string Bruce Richardson
2026-02-17 17:53 ` David Marchand
2026-02-17 17:59 ` Bruce Richardson
2026-02-18 7:43 ` Thierry Herbelot
2026-02-18 8:38 ` David Marchand
2026-02-18 9:41 ` Robin Jarry
2026-03-17 13:57 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1996966.6tgchFWduM@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.