From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <thierry.herbelot@6wind.com>, <dev@dpdk.org>, <rjarry@redhat.com>,
<stable@dpdk.org>
Subject: Re: [PATCH] usertools/pmdinfo: fix search for PMD info string
Date: Tue, 17 Feb 2026 17:59:51 +0000 [thread overview]
Message-ID: <aZSsl2wcdM6RFDKL@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8wcc_+6AY2029ZV8=ft9qYmbztStodF88tVXUS_UPPXMw@mail.gmail.com>
On Tue, Feb 17, 2026 at 06:53:20PM +0100, David Marchand wrote:
> On Tue, 17 Feb 2026 at 13:49, Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > The PMD_INFO_STRING constant string is not guaranteed to appear in the
> > output binary immediately after an unprintable character. Because of
> > this, in some cases the information for a driver could be missed by the
> > PMD info script as it only checks for the prefix at the start of strings
> > that it finds. Change the script to use "s.find()" rather than
> > "s.startswith()" to fix this issue.
> >
> > Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Surprising we hit this issue only now.
Agreed. Two thoughts here:
1. are the compilers normally arranging the data in ways that nearly
guarantee that the strings are not prefixed by other printable data?
2. if we were missing a couple of drivers from dpdk-pmdinfo, would it
really be noticed? Even in the reported case, there were actually 3 missing
driver listings, but only one was actually noticed.
I'd suspect #2 myself. :-)
> Acked-by: David Marchand <david.marchand@redhat.com>
>
> It would be good to hear back from the initial reporter.
>
Agreed. I'd like independent confirmation that this fixes the issue on RHEL
9 as reported.
/Bruce
next prev parent reply other threads:[~2026-02-17 18:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 16:21 [PATCH] drivers/net: reorder Intel drivers list in meson script Thierry Herbelot
2026-01-23 16:27 ` [V2] " Thierry Herbelot
2026-01-23 16:50 ` Bruce Richardson
2026-01-23 16:57 ` Thierry Herbelot
2026-02-16 10:48 ` Bruce Richardson
2026-02-16 11:32 ` Bruce Richardson
2026-02-16 17:39 ` Thomas Monjalon
2026-02-17 12:48 ` [PATCH] usertools/pmdinfo: fix search for PMD info string Bruce Richardson
2026-02-17 17:53 ` David Marchand
2026-02-17 17:59 ` Bruce Richardson [this message]
2026-02-18 7:43 ` Thierry Herbelot
2026-02-18 8:38 ` David Marchand
2026-02-18 9:41 ` Robin Jarry
2026-03-17 13:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZSsl2wcdM6RFDKL@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.