From: Stephan Mueller <smueller@chronox.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] crypto: drbg - fix an error code in drbg_init_sym_kernel()
Date: Fri, 17 Jun 2016 09:23:00 +0000 [thread overview]
Message-ID: <1997601.iEDOaUsuK2@tauon.atsec.com> (raw)
In-Reply-To: <1774858.Ao0ox7E6zA@tauon.atsec.com>
Am Freitag, 17. Juni 2016, 11:19:58 schrieb Stephan Mueller:
Hi Stephan,
> Am Freitag, 17. Juni 2016, 12:16:19 schrieb Dan Carpenter:
>
> Hi Dan,
>
> > We accidentally return PTR_ERR(NULL) which is success but we should
> > return -ENOMEM.
> >
> > Fixes: 355912852115 ('crypto: drbg - use CTR AES instead of ECB AES')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Stephan Mueller <smueller@chronox.de>
>
> That points to an error in the documentation of skcipher_request_alloc.
Apologies, that documentation issue has already been fixed in the
cryptodev-2.6 tree. I was looking at the vanilla 4.6 tree for the
documentation while I was preparing my patch.
Ciao
Stephan
WARNING: multiple messages have this Message-ID (diff)
From: Stephan Mueller <smueller@chronox.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] crypto: drbg - fix an error code in drbg_init_sym_kernel()
Date: Fri, 17 Jun 2016 11:23 +0200 [thread overview]
Message-ID: <1997601.iEDOaUsuK2@tauon.atsec.com> (raw)
In-Reply-To: <1774858.Ao0ox7E6zA@tauon.atsec.com>
Am Freitag, 17. Juni 2016, 11:19:58 schrieb Stephan Mueller:
Hi Stephan,
> Am Freitag, 17. Juni 2016, 12:16:19 schrieb Dan Carpenter:
>
> Hi Dan,
>
> > We accidentally return PTR_ERR(NULL) which is success but we should
> > return -ENOMEM.
> >
> > Fixes: 355912852115 ('crypto: drbg - use CTR AES instead of ECB AES')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: Stephan Mueller <smueller@chronox.de>
>
> That points to an error in the documentation of skcipher_request_alloc.
Apologies, that documentation issue has already been fixed in the
cryptodev-2.6 tree. I was looking at the vanilla 4.6 tree for the
documentation while I was preparing my patch.
Ciao
Stephan
next prev parent reply other threads:[~2016-06-17 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 9:16 [patch] crypto: drbg - fix an error code in drbg_init_sym_kernel() Dan Carpenter
2016-06-17 9:16 ` Dan Carpenter
2016-06-17 9:19 ` Stephan Mueller
2016-06-17 9:19 ` Stephan Mueller
2016-06-17 9:23 ` Stephan Mueller [this message]
2016-06-17 9:23 ` Stephan Mueller
2016-06-20 11:35 ` Herbert Xu
2016-06-20 11:35 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1997601.iEDOaUsuK2@tauon.atsec.com \
--to=smueller@chronox.de \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.