From: Grant Grundler <grundler@rock.cup.hp.com>
To: parisc-linux@thepuffingroup.com
Subject: [parisc-linux] lasi Serial support
Date: Sun, 17 Oct 1999 22:37:45 -0700 (PDT) [thread overview]
Message-ID: <199910180537.WAA20422@rock.cup.hp.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=X-roman8, Size: 673 bytes --]
Hi all,
I just submitted another change to drivers/gecko/lasi.c after reviewing
the code and noting the IMR was being written twice in a row.
But I mainly write to question the location of LASI serial port code.
I don't know if it's "right" to have this code in lasi.c. I'd like
to understand if it is and why. I'm confused because Lasi SCSI support
is in lasi7xx.c. Is it reasonable to create a lasi_RS232.c (or whatever)?
And I'm thinking keeping the lasi.c/h files smaller is a good thing.
One can also modularize the support better (ie put the ifdef in the
Makefile instead). Other thoughts on this?
If it's the "right" thing to do, any volunteers?
thanks,
grant
next reply other threads:[~1999-10-18 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-10-18 5:37 Grant Grundler [this message]
1999-10-18 18:59 ` [parisc-linux] lasi Serial support dkennedy
1999-10-18 20:17 ` Alex deVries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199910180537.WAA20422@rock.cup.hp.com \
--to=grundler@rock.cup.hp.com \
--cc=parisc-linux@thepuffingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.