All of lore.kernel.org
 help / color / mirror / Atom feed
* [parisc-linux] lasi Serial support
@ 1999-10-18  5:37 Grant Grundler
  1999-10-18 18:59 ` dkennedy
  1999-10-18 20:17 ` Alex deVries
  0 siblings, 2 replies; 3+ messages in thread
From: Grant Grundler @ 1999-10-18  5:37 UTC (permalink / raw)
  To: parisc-linux

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=X-roman8, Size: 673 bytes --]

Hi all,
I just submitted another change to drivers/gecko/lasi.c after reviewing
the code and noting the IMR was being written twice in a row.

But I mainly write to question the location of LASI serial port code.
I don't know if it's "right" to have this code in lasi.c.  I'd like
to understand if it is and why. I'm confused because Lasi SCSI support
is in lasi7xx.c.  Is it reasonable to create a lasi_RS232.c (or whatever)?

And I'm thinking keeping the lasi.c/h files smaller is a good thing.
One can also modularize the support better (ie put the ifdef in the
Makefile instead).  Other thoughts on this?
If it's the "right" thing to do, any volunteers?

thanks,
grant

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [parisc-linux] lasi Serial support
  1999-10-18  5:37 [parisc-linux] lasi Serial support Grant Grundler
@ 1999-10-18 18:59 ` dkennedy
  1999-10-18 20:17 ` Alex deVries
  1 sibling, 0 replies; 3+ messages in thread
From: dkennedy @ 1999-10-18 18:59 UTC (permalink / raw)
  To: Grant Grundler; +Cc: parisc-linux

On Sun, 17 Oct 1999, Grant Grundler wrote:

> But I mainly write to question the location of LASI serial port code.
> I don't know if it's "right" to have this code in lasi.c.  I'd like
> to understand if it is and why. I'm confused because Lasi SCSI support
> is in lasi7xx.c.  Is it reasonable to create a lasi_RS232.c (or whatever)?

The reason why it is in lasi7xx.c is because it is called from the
SCSI code and not from anywhere else.  There is no serial code which
goes through a possible list of serial device drivers trying each one.
It was placed in lasi.c to get it working.  I'm not sure exactly where
it is supposed to be either.

We had to do a nasty hack to get the serial console to work.  The
serial console is initialized much before the lasi initialization code
is called.  This should be fixed.  My suggestion was in the serial
console to mark the fact there is supposed to be a serial console, and
then in lasi.c actually initialize it.  I don't know any other way
around the fact that you have to initialize lasi before lasi serial
stuff.

The other idea I had was to create a function which would be called to
check if lasi is initialized.  This function would just return wether or
not it is.  From there, lasi initialization would be called.  The
reason why I think this is because we have a lot of lasi code which
isn't called from the lasi initialization routine (serial console,
scsi) and it would be nice to ensure that lasi is initialized before
_ANY_ of lasi gets used.  Having an implicit requirement that
lasi_init is called before the scsi code is, in my opinion, bad.
Explicitly checking to ensure that the lasi is initialized is better.

> And I'm thinking keeping the lasi.c/h files smaller is a good thing.
> One can also modularize the support better (ie put the ifdef in the
> Makefile instead).  Other thoughts on this?
> If it's the "right" thing to do, any volunteers?

Breaking it out into separate files sounds good to me.  The
initialization routine in lasi.c should call a function call for
initialize of each component of lasi one after another with ifdefs
around each function call.

Does anyone else have any other suggestions?

-- 
David Kennedy
The Puffin Group

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [parisc-linux] lasi Serial support
  1999-10-18  5:37 [parisc-linux] lasi Serial support Grant Grundler
  1999-10-18 18:59 ` dkennedy
@ 1999-10-18 20:17 ` Alex deVries
  1 sibling, 0 replies; 3+ messages in thread
From: Alex deVries @ 1999-10-18 20:17 UTC (permalink / raw)
  To: Grant Grundler; +Cc: parisc-linux

On Sun, 17 Oct 1999, Grant Grundler wrote:
> But I mainly write to question the location of LASI serial port code.
> I don't know if it's "right" to have this code in lasi.c.  I'd like
> to understand if it is and why. I'm confused because Lasi SCSI support
> is in lasi7xx.c.  Is it reasonable to create a lasi_RS232.c (or whatever)?

In part because the serial ports are recognized as a seperate inventory
item, I think it makes sense to move the lasi serial stuff into
drivers/char/lasi_serial.c.  Grant, want to take care of this?

- Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~1999-10-18 20:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
1999-10-18  5:37 [parisc-linux] lasi Serial support Grant Grundler
1999-10-18 18:59 ` dkennedy
1999-10-18 20:17 ` Alex deVries

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.