Re: [EXT] Re: [PATCH v16 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lakshay Piplani <lakshay.piplani@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"lee@kernel.org" <lee@kernel.org>, Frank Li <frank.li@nxp.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Cc: Vikash Bansal <vikash.bansal@nxp.com>,
	Priyanka Jain <priyanka.jain@nxp.com>,
	Aman Kumar Pandey <aman.kumarpandey@nxp.com>
Subject: Re: [EXT] Re: [PATCH v16 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator
Date: Wed, 9 Sep 2026 08:05:22 +0200	[thread overview]
Message-ID: <19a4c144-460b-4dcf-b173-23d14677e2d5@kernel.org> (raw)
In-Reply-To: <AS4PR04MB93626CB21700033FA2DD8AF8FBAC2@AS4PR04MB9362.eurprd04.prod.outlook.com>

On 28/08/2026 18:13, Lakshay Piplani wrote:
> Hi Krzysztof,
> 
> Thanks for the review.
> 
>>> +static const struct of_device_id p3h2x4x_i2c_of_match[] = {
>>> +     { .compatible = "nxp,p3h2440", },
>>> +     { .compatible = "nxp,p3h2441", },
>>> +     { .compatible = "nxp,p3h2840", },
>>> +     { .compatible = "nxp,p3h2841", },
>>
>> So devices are fully compatible? Why isn't this expressed in the binding? Or
>> explained in the commit msg?
>>
> 
> Yes, from this driver's point of view. All four share the register
> interface used by the driver; the port count is read at runtime from
> DEV_CAPAB. The x0/x1 variants differ in their default/debug power-up
> configuration, and the driver applies the DT configuration during probe.
> 
> I will explain this in the binding description and the commit message.

This is not what I asked. Why they are not made compatible?

Best regards,
Krzysztof

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c