From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
linux-kernel@vger.kernel.org, tiwai@suse.com,
lgirdwood@gmail.com, vkoul@kernel.org
Subject: Re: [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters
Date: Wed, 22 Jul 2020 10:36:02 -0500 [thread overview]
Message-ID: <19cfe3fe-4b99-0976-679d-28523d7b9990@linux.intel.com> (raw)
In-Reply-To: <9bbfebf9-9a70-46e3-1808-413d04aa6b2c@linaro.org>
>>> * and the stream properties
>>> + * @set_codec_params: Sets the compressed stream codec parameters,
>>> Optional
>>> + * This can be called in during gapless next track codec change only
>>> to set
>>> + * codec params
>>
>> Would it be clearer if this was called set_next_codec_params()? or
>> set_next_track_codec_params()?
>>
>> Having set_params() and set_codec_params() is a bit confusing since
>> the semantic difference is not captured in the callback name.
>
> set_next_track_codec_params seems more sensible as its next track params.
> Will change this in next version!
maybe set_params() and set_next_track_params() are enough, not sure if
the codec reference helps?
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, vkoul@kernel.org
Subject: Re: [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters
Date: Wed, 22 Jul 2020 10:36:02 -0500 [thread overview]
Message-ID: <19cfe3fe-4b99-0976-679d-28523d7b9990@linux.intel.com> (raw)
In-Reply-To: <9bbfebf9-9a70-46e3-1808-413d04aa6b2c@linaro.org>
>>> * and the stream properties
>>> + * @set_codec_params: Sets the compressed stream codec parameters,
>>> Optional
>>> + * This can be called in during gapless next track codec change only
>>> to set
>>> + * codec params
>>
>> Would it be clearer if this was called set_next_codec_params()? or
>> set_next_track_codec_params()?
>>
>> Having set_params() and set_codec_params() is a bit confusing since
>> the semantic difference is not captured in the callback name.
>
> set_next_track_codec_params seems more sensible as its next track params.
> Will change this in next version!
maybe set_params() and set_next_track_params() are enough, not sure if
the codec reference helps?
next prev parent reply other threads:[~2020-07-22 15:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 17:00 [RFC PATCH v2 0/6] ALSA: compress: add support to change codec profile in gapless playback Srinivas Kandagatla
2020-07-21 17:00 ` Srinivas Kandagatla
2020-07-21 17:00 ` [RFC PATCH v2 1/6] ALSA: compress: move codec parameter check to a function Srinivas Kandagatla
2020-07-21 17:00 ` Srinivas Kandagatla
2020-07-21 19:56 ` Pierre-Louis Bossart
2020-07-21 19:56 ` Pierre-Louis Bossart
2020-07-21 17:00 ` [RFC PATCH v2 2/6] ALSA: compress: add new ioctl for setting codec parameters Srinivas Kandagatla
2020-07-21 17:00 ` Srinivas Kandagatla
2020-07-21 20:05 ` Pierre-Louis Bossart
2020-07-21 20:05 ` Pierre-Louis Bossart
2020-07-22 8:59 ` Srinivas Kandagatla
2020-07-22 8:59 ` Srinivas Kandagatla
2020-07-22 15:36 ` Pierre-Louis Bossart [this message]
2020-07-22 15:36 ` Pierre-Louis Bossart
2020-07-23 4:47 ` Vinod Koul
2020-07-23 4:47 ` Vinod Koul
2020-07-23 13:17 ` Pierre-Louis Bossart
2020-07-23 13:17 ` Pierre-Louis Bossart
2020-07-21 17:00 ` [RFC PATCH v2 3/6] ALSA: compress: add flags to snd_compr_caps to expose dsp caps Srinivas Kandagatla
2020-07-21 17:00 ` Srinivas Kandagatla
2020-07-21 17:00 ` [RFC PATCH v2 4/6] ASoC: compress: add snd_soc_dai_compr_set_codec_params() Srinivas Kandagatla
2020-07-21 17:00 ` Srinivas Kandagatla
2020-07-21 17:00 ` [RFC PATCH v2 5/6] ALSA: compress: bump the version Srinivas Kandagatla
2020-07-21 17:00 ` Srinivas Kandagatla
2020-07-21 17:00 ` [RFC PATCH v2 6/6] ASoC: q6asm-dai: add support to set_codec_params Srinivas Kandagatla
2020-07-21 17:00 ` Srinivas Kandagatla
2020-07-21 20:09 ` Pierre-Louis Bossart
2020-07-21 20:09 ` Pierre-Louis Bossart
2020-07-22 8:59 ` Srinivas Kandagatla
2020-07-22 8:59 ` Srinivas Kandagatla
2020-07-22 14:04 ` Daniel Baluta
2020-07-22 14:04 ` Daniel Baluta
2020-07-23 12:38 ` [RFC PATCH v2 0/6] ALSA: compress: add support to change codec profile in gapless playback Takashi Iwai
2020-07-23 12:38 ` Takashi Iwai
2020-07-23 13:05 ` Vinod Koul
2020-07-23 13:05 ` Vinod Koul
2020-07-23 13:17 ` Takashi Iwai
2020-07-23 13:17 ` Takashi Iwai
2020-07-23 15:56 ` Vinod Koul
2020-07-23 15:56 ` Vinod Koul
2020-07-23 20:33 ` Takashi Iwai
2020-07-23 20:33 ` Takashi Iwai
2020-08-06 11:08 ` Vinod Koul
2020-08-06 11:08 ` Vinod Koul
2020-08-06 16:28 ` Takashi Iwai
2020-08-06 16:28 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19cfe3fe-4b99-0976-679d-28523d7b9990@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.