From: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
To: paulmck@linux.vnet.ibm.com
Cc: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] Reduce size of swap_cgroup by CSS ID
Date: Thu, 5 Feb 2009 22:27:02 +0900 (JST) [thread overview]
Message-ID: <19fabd2ab6062c563832d0caa85deaa7.squirrel@webmail-b.css.fujitsu.com> (raw)
In-Reply-To: <20090205131741.GC6915@linux.vnet.ibm.com>
Paul E. McKenney wrote:
> On Thu, Feb 05, 2009 at 06:59:59PM +0900, KAMEZAWA Hiroyuki wrote:
>> +static struct mem_cgroup *mem_cgroup_lookup_get(unsigned short id)
>> +{
>> + struct cgroup_subsys_state *css;
>> +
>> + /* ID 0 is unused ID */
>> + if (!id)
>> + return NULL;
>> + css = css_lookup(&mem_cgroup_subsys, id);
>> + if (css && css_tryget(css))
>> + return container_of(css, struct mem_cgroup, css);
>
> So css_tryget(), if successful, prevents the structure referenced by
> css from being freed, correct? (If not, the range of the RCU read-side
> critical sections surrounding calls to mem_cgroup_lookup_get() must be
> extended.)
>
One reference to css by css_tryget() prevents rmdir(). So, css will
not be freed until css_put() is called.
Thanks,
-Kame
WARNING: multiple messages have this Message-ID (diff)
From: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
To: paulmck@linux.vnet.ibm.com
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"lizf@cn.fujitsu.com" <lizf@cn.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] Reduce size of swap_cgroup by CSS ID
Date: Thu, 5 Feb 2009 22:27:02 +0900 (JST) [thread overview]
Message-ID: <19fabd2ab6062c563832d0caa85deaa7.squirrel@webmail-b.css.fujitsu.com> (raw)
In-Reply-To: <20090205131741.GC6915@linux.vnet.ibm.com>
Paul E. McKenney wrote:
> On Thu, Feb 05, 2009 at 06:59:59PM +0900, KAMEZAWA Hiroyuki wrote:
>> +static struct mem_cgroup *mem_cgroup_lookup_get(unsigned short id)
>> +{
>> + struct cgroup_subsys_state *css;
>> +
>> + /* ID 0 is unused ID */
>> + if (!id)
>> + return NULL;
>> + css = css_lookup(&mem_cgroup_subsys, id);
>> + if (css && css_tryget(css))
>> + return container_of(css, struct mem_cgroup, css);
>
> So css_tryget(), if successful, prevents the structure referenced by
> css from being freed, correct? (If not, the range of the RCU read-side
> critical sections surrounding calls to mem_cgroup_lookup_get() must be
> extended.)
>
One reference to css by css_tryget() prevents rmdir(). So, css will
not be freed until css_put() is called.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-02-05 13:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 9:59 [RFC][PATCH] Reduce size of swap_cgroup by CSS ID KAMEZAWA Hiroyuki
2009-02-05 9:59 ` KAMEZAWA Hiroyuki
2009-02-05 13:17 ` Paul E. McKenney
2009-02-05 13:17 ` Paul E. McKenney
2009-02-05 13:27 ` KAMEZAWA Hiroyuki [this message]
2009-02-05 13:27 ` KAMEZAWA Hiroyuki
2009-02-06 2:07 ` Li Zefan
2009-02-06 2:07 ` Li Zefan
2009-02-06 2:18 ` KAMEZAWA Hiroyuki
2009-02-06 2:18 ` KAMEZAWA Hiroyuki
2009-02-09 5:55 ` [RFC][PATCH] Reduce size of swap_cgroup by CSS ID v2 KAMEZAWA Hiroyuki
2009-02-09 5:55 ` KAMEZAWA Hiroyuki
2009-02-10 8:07 ` Balbir Singh
2009-02-10 8:07 ` Balbir Singh
2009-02-10 8:50 ` KAMEZAWA Hiroyuki
2009-02-10 8:50 ` KAMEZAWA Hiroyuki
2009-02-23 5:58 ` Daisuke Nishimura
2009-02-23 5:58 ` Daisuke Nishimura
2009-02-24 0:10 ` KAMEZAWA Hiroyuki
2009-02-24 0:10 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19fabd2ab6062c563832d0caa85deaa7.squirrel@webmail-b.css.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.