From: Akio Takebe <takebe_akio@jp.fujitsu.com>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, jeremy@goop.org,
hollisb@us.ibm.com, kvm-devel@lists.sourceforge.net,
avi@qumranet.com, Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: Re: [kvm-devel] include files for kvmclock
Date: Wed, 07 Nov 2007 22:27:46 +0900 [thread overview]
Message-ID: <1FC82141FC3CCFtakebe_akio@jp.fujitsu.com> (raw)
In-Reply-To: <4731BAB2.9040004@redhat.com>
Hi,
>> Why does kvm_hv_clock need page_align?
>Each vcpu will register a page on its own. In the guest side, it will be
>an array of pages. So, we make it page sized.
>
>> And also the kvm_hv_clock is alloced with kvm_vcpu,
>There's no requirements on the host part at all. So it doesn't really
>matter. In the next version, I may make it even a simple pointer.
>
>> so the align is not enough, isn't it?
>> I thik __atribute__((__aligne__(PAGE_SIZE)))) is better than it.
>It deals with the start of the structure, but not with its size. See the
>guest part: Where it matters, I do use it.
Oh, I confused the guest/host part, but I could understand it.
Thank you for your explanation.
Best Regards,
Akio Takebe
WARNING: multiple messages have this Message-ID (diff)
From: Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Glauber de Oliveira Costa
<gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: jeremy-TSDbQ3PG+2Y@public.gmane.org,
hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org
Subject: Re: include files for kvmclock
Date: Wed, 07 Nov 2007 22:27:46 +0900 [thread overview]
Message-ID: <1FC82141FC3CCFtakebe_akio@jp.fujitsu.com> (raw)
In-Reply-To: <4731BAB2.9040004-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi,
>> Why does kvm_hv_clock need page_align?
>Each vcpu will register a page on its own. In the guest side, it will be
>an array of pages. So, we make it page sized.
>
>> And also the kvm_hv_clock is alloced with kvm_vcpu,
>There's no requirements on the host part at all. So it doesn't really
>matter. In the next version, I may make it even a simple pointer.
>
>> so the align is not enough, isn't it?
>> I thik __atribute__((__aligne__(PAGE_SIZE)))) is better than it.
>It deals with the start of the structure, but not with its size. See the
>guest part: Where it matters, I do use it.
Oh, I confused the guest/host part, but I could understand it.
Thank you for your explanation.
Best Regards,
Akio Takebe
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-11-07 13:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 22:18 KVM paravirt clocksource - Take 3 out of <put your number here> Glauber de Oliveira Costa
2007-11-06 22:18 ` Glauber de Oliveira Costa
2007-11-06 22:18 ` include files for kvmclock Glauber de Oliveira Costa
2007-11-06 22:18 ` Glauber de Oliveira Costa
2007-11-06 21:35 ` [kvm-devel] " Glauber de Oliveira Costa
2007-11-06 21:35 ` Glauber de Oliveira Costa
2007-11-07 5:55 ` [kvm-devel] " Avi Kivity
2007-11-07 5:55 ` Avi Kivity
2007-11-07 5:58 ` [kvm-devel] " Jeremy Fitzhardinge
2007-11-07 5:58 ` Jeremy Fitzhardinge
2007-11-07 12:49 ` [kvm-devel] " Glauber de Oliveira Costa
2007-11-07 12:49 ` Glauber de Oliveira Costa
2007-11-06 22:18 ` kvmclock - the host part Glauber de Oliveira Costa
2007-11-06 22:18 ` Glauber de Oliveira Costa
2007-11-06 22:18 ` kvmclock implementation, the guest part Glauber de Oliveira Costa
2007-11-06 22:18 ` Glauber de Oliveira Costa
2007-11-07 5:50 ` kvmclock - the host part Avi Kivity
2007-11-07 5:50 ` Avi Kivity
2007-11-07 13:08 ` Glauber de Oliveira Costa
2007-11-07 13:08 ` Glauber de Oliveira Costa
2007-11-07 13:59 ` Avi Kivity
2007-11-06 22:50 ` include files for kvmclock Jeremy Fitzhardinge
2007-11-06 22:50 ` Jeremy Fitzhardinge
2007-11-06 22:58 ` Glauber de Oliveira Costa
2007-11-06 22:58 ` Glauber de Oliveira Costa
2007-11-07 8:16 ` [kvm-devel] " Akio Takebe
2007-11-07 8:16 ` Akio Takebe
2007-11-07 13:16 ` [kvm-devel] " Glauber de Oliveira Costa
2007-11-07 13:16 ` Glauber de Oliveira Costa
2007-11-07 13:27 ` Akio Takebe [this message]
2007-11-07 13:27 ` Akio Takebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1FC82141FC3CCFtakebe_akio@jp.fujitsu.com \
--to=takebe_akio@jp.fujitsu.com \
--cc=avi@qumranet.com \
--cc=gcosta@redhat.com \
--cc=hollisb@us.ibm.com \
--cc=jeremy@goop.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.